open-orchestra/open-orchestra-cms-bundle

View on GitHub
Backoffice/Form/Type/BlockType.php

Summary

Maintainability
C
1 day
Test Coverage

Method configureOptions has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function configureOptions(OptionsResolver $resolver)
    {
        $resolver->setDefaults(
            array(
                'data_class' => null,
Severity: Minor
Found in Backoffice/Form/Type/BlockType.php - About 1 hr to fix

Method buildForm has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function buildForm(FormBuilderInterface $builder, array $options)
    {
        $builder->add('label', 'text', array(
            'label' => 'open_orchestra_backoffice.form.block.label',
            'constraints' => new NotBlank(),
Severity: Minor
Found in Backoffice/Form/Type/BlockType.php - About 1 hr to fix

Function getStyleChoices has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    protected function getStyleChoices(array $options)
    {
        $choices = array();
        if (
            isset($options['data']) &&
Severity: Minor
Found in Backoffice/Form/Type/BlockType.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

        TemplateManager $templateManager,
        ContextBackOfficeInterface $contextManager,
        SiteRepositoryInterface $siteRepository,
        GenerateFormManager $generateFormManager,
        BlockToArrayTransformer $blockToArrayTransformer,
Severity: Minor
Found in Backoffice/Form/Type/BlockType.php - About 45 mins to fix

The class BlockType has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13.
Open

class BlockType extends AbstractType
{
    protected $blockClass;
    protected $templateManager;
    protected $contextManager;
Severity: Minor
Found in Backoffice/Form/Type/BlockType.php by phpmd

CouplingBetweenObjects

Since: 1.1.0

A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

Example

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Source https://phpmd.org/rules/design.html#couplingbetweenobjects

Parameter $builder has undeclared type \Symfony\Component\Form\FormBuilderInterface
Open

    public function buildForm(FormBuilderInterface $builder, array $options)
Severity: Minor
Found in Backoffice/Form/Type/BlockType.php by phan

Call to method add from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

            $builder->add('style', 'choice', array(
Severity: Critical
Found in Backoffice/Form/Type/BlockType.php by phan

Call to method addEventSubscriber from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

        $builder->addEventSubscriber($this->blockFormTypeSubscriber);
Severity: Critical
Found in Backoffice/Form/Type/BlockType.php by phan

Parameter $form has undeclared type \Symfony\Component\Form\FormInterface
Open

    public function buildView(FormView $view, FormInterface $form, array $options)
Severity: Minor
Found in Backoffice/Form/Type/BlockType.php by phan

Class extends undeclared class \Symfony\Component\Form\AbstractType
Open

class BlockType extends AbstractType
Severity: Critical
Found in Backoffice/Form/Type/BlockType.php by phan

Call to method add from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

            $builder->add('code', 'text', array(
Severity: Critical
Found in Backoffice/Form/Type/BlockType.php by phan

Parameter $siteRepository has undeclared type \OpenOrchestra\ModelInterface\Repository\SiteRepositoryInterface
Open

    public function __construct(
Severity: Minor
Found in Backoffice/Form/Type/BlockType.php by phan

Checking instanceof against undeclared class \OpenOrchestra\ModelInterface\Model\BlockInterface
Open

            $options['data'] instanceof BlockInterface &&
Severity: Critical
Found in Backoffice/Form/Type/BlockType.php by phan

Call to method findOneBySiteId from undeclared class \OpenOrchestra\ModelInterface\Repository\SiteRepositoryInterface
Open

            $site = $this->siteRepository->findOneBySiteId($siteId);
Severity: Critical
Found in Backoffice/Form/Type/BlockType.php by phan

Reference to undeclared class \Symfony\Component\Form\AbstractType
Open

        parent::buildView($view, $form, $options);
Severity: Critical
Found in Backoffice/Form/Type/BlockType.php by phan

Checking instanceof against undeclared class \OpenOrchestra\ModelInterface\Model\BlockInterface
Open

            $options['data'] instanceof BlockInterface
Severity: Critical
Found in Backoffice/Form/Type/BlockType.php by phan

Call to method addViewTransformer from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

        $builder->addViewTransformer($this->blockToArrayTransformer);
Severity: Critical
Found in Backoffice/Form/Type/BlockType.php by phan

Call to method setAttribute from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

            $builder->setAttribute('disabled', $options['disabled']);
Severity: Critical
Found in Backoffice/Form/Type/BlockType.php by phan

Reference to instance property vars from undeclared class \Symfony\Component\Form\FormView
Open

        $view->vars['delete_button'] = $options['delete_button'];
Severity: Minor
Found in Backoffice/Form/Type/BlockType.php by phan

Reference to instance property vars from undeclared class \Symfony\Component\Form\FormView
Open

        $view->vars['new_button'] = $options['new_button'];
Severity: Minor
Found in Backoffice/Form/Type/BlockType.php by phan

Call to method __construct from undeclared class \Symfony\Component\Validator\Constraints\NotBlank
Open

            'constraints' => new NotBlank(),
Severity: Critical
Found in Backoffice/Form/Type/BlockType.php by phan

Call to method setDefaults from undeclared class \Symfony\Component\OptionsResolver\OptionsResolver
Open

        $resolver->setDefaults(
Severity: Critical
Found in Backoffice/Form/Type/BlockType.php by phan

Call to method add from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

        $builder->add('label', 'text', array(
Severity: Critical
Found in Backoffice/Form/Type/BlockType.php by phan

Parameter $view has undeclared type \Symfony\Component\Form\FormView
Open

    public function buildView(FormView $view, FormInterface $form, array $options)
Severity: Minor
Found in Backoffice/Form/Type/BlockType.php by phan

Call to method setAttribute from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

        $builder->setAttribute('template', $this->generateFormManager->getTemplate($options['data']));
Severity: Critical
Found in Backoffice/Form/Type/BlockType.php by phan

Expected @param annotation for siteRepository to be before the @param annotation for generateFormManager
Open

     * @param GenerateFormManager        $generateFormManager
Severity: Info
Found in Backoffice/Form/Type/BlockType.php by phan

Call with 1 arg(s) to \OpenOrchestra\Backoffice\Validator\Constraints\UniqueBlockCode::__construct() which only takes 0 arg(s) defined at /code/Backoffice/Validator/Constraints/UniqueBlockCode.php:10
Open

                'constraints' => new UniqueBlockCode(array(
Severity: Info
Found in Backoffice/Form/Type/BlockType.php by phan

Parameter $resolver has undeclared type \Symfony\Component\OptionsResolver\OptionsResolver
Open

    public function configureOptions(OptionsResolver $resolver)
Severity: Minor
Found in Backoffice/Form/Type/BlockType.php by phan

Parameter $blockFormTypeSubscriber has undeclared type \Symfony\Component\EventDispatcher\EventSubscriberInterface
Open

    public function __construct(
Severity: Minor
Found in Backoffice/Form/Type/BlockType.php by phan

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        $resolver->setDefaults(
            array(
                'data_class' => null,
                'delete_button' => false,
                'new_button' => false,
Severity: Major
Found in Backoffice/Form/Type/BlockType.php and 1 other location - About 5 hrs to fix
Backoffice/Tests/Form/Type/BlockTypeTest.php on lines 97..142

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 193.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid excessively long variable names like $blockToArrayTransformer. Keep variable name length under 20.
Open

        BlockToArrayTransformer $blockToArrayTransformer,
Severity: Minor
Found in Backoffice/Form/Type/BlockType.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $blockFormTypeSubscriber. Keep variable name length under 20.
Open

    protected $blockFormTypeSubscriber;
Severity: Minor
Found in Backoffice/Form/Type/BlockType.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $blockToArrayTransformer. Keep variable name length under 20.
Open

    protected $blockToArrayTransformer;
Severity: Minor
Found in Backoffice/Form/Type/BlockType.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $blockFormTypeSubscriber. Keep variable name length under 20.
Open

        EventSubscriberInterface $blockFormTypeSubscriber
Severity: Minor
Found in Backoffice/Form/Type/BlockType.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $templateSetParameters. Keep variable name length under 20.
Open

            $templateSetParameters = $this->templateManager->getTemplateSetParameters();
Severity: Minor
Found in Backoffice/Form/Type/BlockType.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Line exceeds 120 characters; contains 124 characters
Open

                    (empty($configuration['allowed_blocks']) || in_array($blockComponent, $configuration['allowed_blocks']))

Expected 0 spaces after opening bracket; newline found
Open

        if (

Expected 0 spaces after opening bracket; newline found
Open

                if (

Expected 0 spaces after opening bracket; newline found
Open

        if (

There are no issues that match your filters.

Category
Status