open-orchestra/open-orchestra-cms-bundle

View on GitHub
Backoffice/Form/Type/ContentType.php

Summary

Maintainability
C
1 day
Test Coverage

Method buildForm has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function buildForm(FormBuilderInterface $builder, array $options)
    {
        $builder
            ->add('name', 'text', array(
                'label' => 'open_orchestra_backoffice.form.content.name',
Severity: Minor
Found in Backoffice/Form/Type/ContentType.php - About 1 hr to fix

Method configureOptions has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function configureOptions(OptionsResolver $resolver)
    {
        $resolver->setDefaults(array(
            'data_class' => $this->contentClass,
            'is_statusable' => false,
Severity: Minor
Found in Backoffice/Form/Type/ContentType.php - About 1 hr to fix

Parameter $statusableChoiceStatusSubscriber has undeclared type \Symfony\Component\EventDispatcher\EventSubscriberInterface
Open

    public function __construct(
Severity: Minor
Found in Backoffice/Form/Type/ContentType.php by phan

Reference to instance property vars from undeclared class \Symfony\Component\Form\FormView
Open

        $view->vars['delete_button'] = $options['delete_button'];
Severity: Minor
Found in Backoffice/Form/Type/ContentType.php by phan

Class extends undeclared class \Symfony\Component\Form\AbstractType
Open

class ContentType extends AbstractType
Severity: Critical
Found in Backoffice/Form/Type/ContentType.php by phan

Reference to instance property vars from undeclared class \Symfony\Component\Form\FormView
Open

        $view->vars['enable_delete_button'] = $options['enable_delete_button'];
Severity: Minor
Found in Backoffice/Form/Type/ContentType.php by phan

Reference to instance property vars from undeclared class \Symfony\Component\Form\FormView
Open

        $view->vars['new_button'] = $options['new_button'];
Severity: Minor
Found in Backoffice/Form/Type/ContentType.php by phan

Call to method add from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

            $builder
Severity: Critical
Found in Backoffice/Form/Type/ContentType.php by phan

Parameter $view has undeclared type \Symfony\Component\Form\FormView
Open

    public function buildView(FormView $view, FormInterface $form, array $options)
Severity: Minor
Found in Backoffice/Form/Type/ContentType.php by phan

Reference to undeclared class \Symfony\Component\Form\AbstractType
Open

        parent::buildView($view, $form, $options);
Severity: Critical
Found in Backoffice/Form/Type/ContentType.php by phan

Call to method setDefaults from undeclared class \Symfony\Component\OptionsResolver\OptionsResolver
Open

        $resolver->setDefaults(array(
Severity: Critical
Found in Backoffice/Form/Type/ContentType.php by phan

Parameter $builder has undeclared type \Symfony\Component\Form\FormBuilderInterface
Open

    public function buildForm(FormBuilderInterface $builder, array $options)
Severity: Minor
Found in Backoffice/Form/Type/ContentType.php by phan

Parameter $contentTypeSubscriber has undeclared type \Symfony\Component\EventDispatcher\EventSubscriberInterface
Open

    public function __construct(
Severity: Minor
Found in Backoffice/Form/Type/ContentType.php by phan

Call to method add from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

            $builder->add('linkedToSite', 'checkbox', array(
Severity: Critical
Found in Backoffice/Form/Type/ContentType.php by phan

Call to method addEventSubscriber from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

        $builder->addEventSubscriber($this->contentTypeSubscriber);
Severity: Critical
Found in Backoffice/Form/Type/ContentType.php by phan

Reference to instance property vars from undeclared class \Symfony\Component\Form\FormView
Open

        $view->vars['delete_help_text'] = $options['delete_help_text'];
Severity: Minor
Found in Backoffice/Form/Type/ContentType.php by phan

Call to method addEventSubscriber from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

            $builder->addEventSubscriber($this->statusableChoiceStatusSubscriber);
Severity: Critical
Found in Backoffice/Form/Type/ContentType.php by phan

Parameter $resolver has undeclared type \Symfony\Component\OptionsResolver\OptionsResolver
Open

    public function configureOptions(OptionsResolver $resolver)
Severity: Minor
Found in Backoffice/Form/Type/ContentType.php by phan

Call to method setAttribute from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

            $builder->setAttribute('disabled', $options['disabled']);
Severity: Critical
Found in Backoffice/Form/Type/ContentType.php by phan

Parameter $form has undeclared type \Symfony\Component\Form\FormInterface
Open

    public function buildView(FormView $view, FormInterface $form, array $options)
Severity: Minor
Found in Backoffice/Form/Type/ContentType.php by phan

Call to method add from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

        $builder
Severity: Critical
Found in Backoffice/Form/Type/ContentType.php by phan

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        $resolver->setDefaults(array(
            'data_class' => $this->contentClass,
            'is_statusable' => false,
            'need_link_to_site_defintion' => false,
            'delete_button' => false,
Severity: Major
Found in Backoffice/Form/Type/ContentType.php and 1 other location - About 3 hrs to fix
Backoffice/Tests/Form/Type/ContentTypeTest.php on lines 95..128

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 157.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public function buildView(FormView $view, FormInterface $form, array $options)
    {
        parent::buildView($view, $form, $options);
        $view->vars['enable_delete_button'] = $options['enable_delete_button'];
        $view->vars['delete_help_text'] = $options['delete_help_text'];
Severity: Major
Found in Backoffice/Form/Type/ContentType.php and 2 other locations - About 1 hr to fix
Backoffice/Form/Type/ContentTypeType.php on lines 189..196
GroupBundle/Form/Type/GroupType.php on lines 153..160

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid excessively long variable names like $contentTypeSubscriber. Keep variable name length under 20.
Open

        EventSubscriberInterface $contentTypeSubscriber,
Severity: Minor
Found in Backoffice/Form/Type/ContentType.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $statusableChoiceStatusSubscriber. Keep variable name length under 20.
Open

    protected $statusableChoiceStatusSubscriber;
Severity: Minor
Found in Backoffice/Form/Type/ContentType.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $statusableChoiceStatusSubscriber. Keep variable name length under 20.
Open

        EventSubscriberInterface $statusableChoiceStatusSubscriber,
Severity: Minor
Found in Backoffice/Form/Type/ContentType.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $contentTypeSubscriber. Keep variable name length under 20.
Open

    protected $contentTypeSubscriber;
Severity: Minor
Found in Backoffice/Form/Type/ContentType.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

There are no issues that match your filters.

Category
Status