open-orchestra/open-orchestra-cms-bundle

View on GitHub
Backoffice/Form/Type/ContentTypeType.php

Summary

Maintainability
C
1 day
Test Coverage

Method buildForm has 78 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function buildForm(FormBuilderInterface $builder, array $options)
    {
        $builder
            ->add('names', 'oo_multi_languages', array(
                'label' => 'open_orchestra_backoffice.form.content_type.names',
Severity: Major
Found in Backoffice/Form/Type/ContentTypeType.php - About 3 hrs to fix

Method configureOptions has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function configureOptions(OptionsResolver $resolver)
    {
        $resolver->setDefaults(
            array(
                'data_class' => $this->contentTypeClass,
Severity: Minor
Found in Backoffice/Form/Type/ContentTypeType.php - About 1 hr to fix

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        $contentTypeClass,
        TranslatorInterface $translator,
        array $backOfficeLanguages,
        ContentTypeTypeSubscriber $contentTypeTypeSubscriber,
        ContentTypeStatusableSubscriber $contentTypeStatusableSubscriber
Severity: Minor
Found in Backoffice/Form/Type/ContentTypeType.php - About 35 mins to fix

Call to method addEventSubscriber from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

        $builder->addEventSubscriber($this->contentTypeStatusableSubscriber);
Severity: Critical
Found in Backoffice/Form/Type/ContentTypeType.php by phan

Reference to instance property vars from undeclared class \Symfony\Component\Form\FormView
Open

        $view->vars['enable_delete_button'] = $options['enable_delete_button'];

Call to method add from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

            $builder
Severity: Critical
Found in Backoffice/Form/Type/ContentTypeType.php by phan

Call to method addEventSubscriber from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

        $builder->addEventSubscriber($this->contentTypeTypeSubscriber);
Severity: Critical
Found in Backoffice/Form/Type/ContentTypeType.php by phan

Parameter $resolver has undeclared type \Symfony\Component\OptionsResolver\OptionsResolver
Open

    public function configureOptions(OptionsResolver $resolver)

Parameter $view has undeclared type \Symfony\Component\Form\FormView
Open

    public function buildView(FormView $view, FormInterface $form, array $options)

Reference to instance property vars from undeclared class \Symfony\Component\Form\FormView
Open

        $view->vars['delete_help_text'] = $options['delete_help_text'];

Reference to instance property vars from undeclared class \Symfony\Component\Form\FormView
Open

        $view->vars['new_button'] = $options['new_button'];

Call to method trans from undeclared class \Symfony\Component\Translation\TranslatorInterface
Open

                    'data-prototype-label-remove' => $this->translator->trans('open_orchestra_backoffice.form.field_type.delete'),
Severity: Critical
Found in Backoffice/Form/Type/ContentTypeType.php by phan

Reference to undeclared class \Symfony\Component\Form\AbstractType
Open

        parent::buildView($view, $form, $options);
Severity: Critical
Found in Backoffice/Form/Type/ContentTypeType.php by phan

Parameter $builder has undeclared type \Symfony\Component\Form\FormBuilderInterface
Open

    public function buildForm(FormBuilderInterface $builder, array $options)

Call to method trans from undeclared class \Symfony\Component\Translation\TranslatorInterface
Open

                    'data-prototype-label-add' => $this->translator->trans('open_orchestra_backoffice.form.field_type.add'),
Severity: Critical
Found in Backoffice/Form/Type/ContentTypeType.php by phan

Class extends undeclared class \Symfony\Component\Form\AbstractType
Open

class ContentTypeType extends AbstractType
Severity: Critical
Found in Backoffice/Form/Type/ContentTypeType.php by phan

Call to method setAttribute from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

            $builder->setAttribute('disabled', $options['disabled']);
Severity: Critical
Found in Backoffice/Form/Type/ContentTypeType.php by phan

Parameter $form has undeclared type \Symfony\Component\Form\FormInterface
Open

    public function buildView(FormView $view, FormInterface $form, array $options)

Call to method add from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

        $builder
Severity: Critical
Found in Backoffice/Form/Type/ContentTypeType.php by phan

Call to method trans from undeclared class \Symfony\Component\Translation\TranslatorInterface
Open

                    'data-prototype-label-new' => $this->translator->trans('open_orchestra_backoffice.form.field_type.new'),
Severity: Critical
Found in Backoffice/Form/Type/ContentTypeType.php by phan

Call to method setDefaults from undeclared class \Symfony\Component\OptionsResolver\OptionsResolver
Open

        $resolver->setDefaults(
Severity: Critical
Found in Backoffice/Form/Type/ContentTypeType.php by phan

Reference to instance property vars from undeclared class \Symfony\Component\Form\FormView
Open

        $view->vars['delete_button'] = $options['delete_button'];

Parameter $translator has undeclared type \Symfony\Component\Translation\TranslatorInterface
Open

    public function __construct(

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        $resolver->setDefaults(
            array(
                'data_class' => $this->contentTypeClass,
                'need_link_to_site_defintion' => false,
                'delete_button' => false,
Severity: Major
Found in Backoffice/Form/Type/ContentTypeType.php and 1 other location - About 4 hrs to fix
Backoffice/Tests/Form/Type/ContentTypeTypeTest.php on lines 81..123

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 181.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public function buildView(FormView $view, FormInterface $form, array $options)
    {
        parent::buildView($view, $form, $options);
        $view->vars['delete_button'] = $options['delete_button'];
        $view->vars['enable_delete_button'] = $options['enable_delete_button'];
Severity: Major
Found in Backoffice/Form/Type/ContentTypeType.php and 2 other locations - About 1 hr to fix
Backoffice/Form/Type/ContentType.php on lines 90..97
GroupBundle/Form/Type/GroupType.php on lines 153..160

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid excessively long variable names like $contentTypeTypeSubscriber. Keep variable name length under 20.
Open

        ContentTypeTypeSubscriber $contentTypeTypeSubscriber,

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $contentTypeStatusableSubscriber. Keep variable name length under 20.
Open

        ContentTypeStatusableSubscriber $contentTypeStatusableSubscriber

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $contentTypeTypeSubscriber. Keep variable name length under 20.
Open

    protected $contentTypeTypeSubscriber;

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $contentTypeStatusableSubscriber. Keep variable name length under 20.
Open

    protected $contentTypeStatusableSubscriber;

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Line exceeds 120 characters; contains 124 characters
Open

                    'data-prototype-label-new' => $this->translator->trans('open_orchestra_backoffice.form.field_type.new'),

Line exceeds 120 characters; contains 124 characters
Open

                    'data-prototype-label-add' => $this->translator->trans('open_orchestra_backoffice.form.field_type.add'),

Line exceeds 120 characters; contains 130 characters
Open

                    'data-prototype-label-remove' => $this->translator->trans('open_orchestra_backoffice.form.field_type.delete'),

Line exceeds 120 characters; contains 122 characters
Open

                'attr' => array('help_text' => 'open_orchestra_backoffice.form.content_type.defining_versionable.helper'),

Line exceeds 120 characters; contains 121 characters
Open

                'attr' => array('help_text' => 'open_orchestra_backoffice.form.content_type.defining_statusable.helper'),

There are no issues that match your filters.

Category
Status