Backoffice/Form/Type/Extension/AccordionExtension.php
Function buildView
has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
Open
public function buildView(FormView $view, FormInterface $form, array $options)
{
if ($form->getParent() &&
$form->getParent()->getConfig()->getType()->getName() == 'collection' &&
$form->getConfig()->getOption('columns')
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The method buildView uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$child = false;
break;
}
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid unused parameters such as '$options'. Open
Open
public function buildView(FormView $view, FormInterface $form, array $options)
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Call to method getConfig
from undeclared class \Symfony\Component\Form\FormInterface
Open
Open
$columns = $form->getConfig()->getOption('columns');
- Create a ticketCreate a ticket
- Exclude checks
Class extends undeclared class \Symfony\Component\Form\AbstractTypeExtension
Open
Open
class AccordionExtension extends AbstractTypeExtension
- Create a ticketCreate a ticket
- Exclude checks
Call to method getConfig
from undeclared class \Symfony\Component\Form\FormInterface
Open
Open
$form->getConfig()->getOption('columns')
- Create a ticketCreate a ticket
- Exclude checks
Call to method getParent
from undeclared class \Symfony\Component\Form\FormInterface
Open
Open
$form->getParent()->getConfig()->getType()->getName() == 'collection' &&
- Create a ticketCreate a ticket
- Exclude checks
Call to method get
from undeclared class \Symfony\Component\Form\FormInterface
Open
Open
$child = $child->get($columnDefinition);
- Create a ticketCreate a ticket
- Exclude checks
Reference to instance property vars
from undeclared class \Symfony\Component\Form\FormView
Open
Open
$view->vars['columns'][$column] = array(
- Create a ticketCreate a ticket
- Exclude checks
Parameter $view
has undeclared type \Symfony\Component\Form\FormView
Open
Open
public function buildView(FormView $view, FormInterface $form, array $options)
- Create a ticketCreate a ticket
- Exclude checks
Call to method getParent
from undeclared class \Symfony\Component\Form\FormInterface
Open
Open
if ($form->getParent() &&
- Create a ticketCreate a ticket
- Exclude checks
Parameter $form
has undeclared type \Symfony\Component\Form\FormInterface
Open
Open
public function buildView(FormView $view, FormInterface $form, array $options)
- Create a ticketCreate a ticket
- Exclude checks
Call to method has
from undeclared class \Symfony\Component\Form\FormInterface
Open
Open
if ($child->has($columnDefinition)) {
- Create a ticketCreate a ticket
- Exclude checks
Expected 1 space after FOREACH keyword; 0 found Open
Open
foreach($columnsDefinition as $columnDefinition) {
- Create a ticketCreate a ticket
- Exclude checks