Sign upLogin

open-orchestra/open-orchestra-cms-bundle

View on GitHub
Star
Backoffice/Form/Type/SiteType.php

Summary

Maintainability
D
1 day
Test Coverage

Method buildForm has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function buildForm(FormBuilderInterface $builder, array $options)
    {
        $builder
            ->add('name', 'text', array(
                'label' => 'open_orchestra_backoffice.form.website.name',
Severity: Major
Found in Backoffice/Form/Type/SiteType.php - About 2 hrs to fix

Method configureOptions has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function configureOptions(OptionsResolver $resolver)
    {
        $resolver->setDefaults(
            array(
                'data_class' => $this->siteClass,
Severity: Major
Found in Backoffice/Form/Type/SiteType.php - About 2 hrs to fix

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        $siteClass,
        TranslatorInterface $translator,
        TemplateManager $templateManager,
        EventSubscriberInterface $webSiteSubscriber,
        EventDispatcherInterface $eventDispatcher
Severity: Minor
Found in Backoffice/Form/Type/SiteType.php - About 35 mins to fix

Parameter $eventDispatcher has undeclared type \Symfony\Component\EventDispatcher\EventDispatcherInterface
Open

    public function __construct(
Severity: Minor
Found in Backoffice/Form/Type/SiteType.php by phan

Call to method addEventSubscriber from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

        $builder->addEventSubscriber(new WebSiteNodeTemplateSubscriber($this->templateManager));
Severity: Critical
Found in Backoffice/Form/Type/SiteType.php by phan

Reference to undeclared class \Symfony\Component\Form\AbstractType
Open

        parent::buildView($view, $form, $options);
Severity: Critical
Found in Backoffice/Form/Type/SiteType.php by phan

Call to method setDefaults from undeclared class \Symfony\Component\OptionsResolver\OptionsResolver
Open

        $resolver->setDefaults(
Severity: Critical
Found in Backoffice/Form/Type/SiteType.php by phan

Reference to instance property vars from undeclared class \Symfony\Component\Form\FormView
Open

        $view->vars['delete_button'] = $options['delete_button'];
Severity: Minor
Found in Backoffice/Form/Type/SiteType.php by phan

Call to method addEventSubscriber from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

        $builder->addEventSubscriber($this->webSiteSubscriber);
Severity: Critical
Found in Backoffice/Form/Type/SiteType.php by phan

Call to method trans from undeclared class \Symfony\Component\Translation\TranslatorInterface
Open

                    'data-prototype-label-remove' => $this->translator->trans('open_orchestra_backoffice.form.delete'),
Severity: Critical
Found in Backoffice/Form/Type/SiteType.php by phan

Parameter $webSiteSubscriber has undeclared type \Symfony\Component\EventDispatcher\EventSubscriberInterface
Open

    public function __construct(
Severity: Minor
Found in Backoffice/Form/Type/SiteType.php by phan

Call to method add from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

        $builder
Severity: Critical
Found in Backoffice/Form/Type/SiteType.php by phan

Call to method getData from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

                'constraints' => array(new UnremovableLanguageCondition($builder->getData())),
Severity: Critical
Found in Backoffice/Form/Type/SiteType.php by phan

Parameter $form has undeclared type \Symfony\Component\Form\FormInterface
Open

    public function buildView(FormView $view, FormInterface $form, array $options)
Severity: Minor
Found in Backoffice/Form/Type/SiteType.php by phan

Call to method dispatch from undeclared class \Symfony\Component\EventDispatcher\EventDispatcherInterface
Open

        $this->eventDispatcher->dispatch(SiteFormEvents::SITE_FORM_CREATION, new SiteFormEvent($builder));
Severity: Critical
Found in Backoffice/Form/Type/SiteType.php by phan

Parameter $builder has undeclared type \Symfony\Component\Form\FormBuilderInterface
Open

    public function buildForm(FormBuilderInterface $builder, array $options)
Severity: Minor
Found in Backoffice/Form/Type/SiteType.php by phan

Parameter $translator has undeclared type \Symfony\Component\Translation\TranslatorInterface
Open

    public function __construct(
Severity: Minor
Found in Backoffice/Form/Type/SiteType.php by phan

Call to method trans from undeclared class \Symfony\Component\Translation\TranslatorInterface
Open

                    'data-prototype-label-add' => $this->translator->trans('open_orchestra_backoffice.form.website.add_alias'),
Severity: Critical
Found in Backoffice/Form/Type/SiteType.php by phan

Parameter $view has undeclared type \Symfony\Component\Form\FormView
Open

    public function buildView(FormView $view, FormInterface $form, array $options)
Severity: Minor
Found in Backoffice/Form/Type/SiteType.php by phan

Class extends undeclared class \Symfony\Component\Form\AbstractType
Open

class SiteType extends AbstractType
Severity: Critical
Found in Backoffice/Form/Type/SiteType.php by phan

Reference to instance property vars from undeclared class \Symfony\Component\Form\FormView
Open

        $view->vars['new_button'] = $options['new_button'];
Severity: Minor
Found in Backoffice/Form/Type/SiteType.php by phan

Call to method setAttribute from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

            $builder->setAttribute('disabled', $options['disabled']);
Severity: Critical
Found in Backoffice/Form/Type/SiteType.php by phan

Parameter $resolver has undeclared type \Symfony\Component\OptionsResolver\OptionsResolver
Open

    public function configureOptions(OptionsResolver $resolver)
Severity: Minor
Found in Backoffice/Form/Type/SiteType.php by phan

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        $resolver->setDefaults(
            array(
                'data_class' => $this->siteClass,
                'delete_button' => false,
                'new_button' => false,
Severity: Major
Found in Backoffice/Form/Type/SiteType.php and 1 other location - About 7 hrs to fix
Backoffice/Tests/Form/Type/SiteTypeTest.php on lines 88..147

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 240.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There must be a single space between the closing parenthesis and the opening brace of a multi-line function declaration; found 0 spaces
Open

    ){
Severity: Minor
Found in Backoffice/Form/Type/SiteType.php by phpcodesniffer

Line exceeds 120 characters; contains 127 characters
Open

                    'data-prototype-label-add' => $this->translator->trans('open_orchestra_backoffice.form.website.add_alias'),
Severity: Minor
Found in Backoffice/Form/Type/SiteType.php by phpcodesniffer

There are no issues that match your filters.

Category
Status