Method voteOnAttribute
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function voteOnAttribute($attribute, $subject, TokenInterface $token)
{
if ($this->isSuperAdmin($token)) {
return true;
}
- Create a ticketCreate a ticket
Function voteOnAttribute
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
protected function voteOnAttribute($attribute, $subject, TokenInterface $token)
{
if ($this->isSuperAdmin($token)) {
return true;
}
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this method. Open
return $this->voteForUser($subject, $user);
- Create a ticketCreate a ticket
Avoid too many return
statements within this method. Open
return $this->canActOnSite($subject->getSite()->getSiteId(), $user);
- Create a ticketCreate a ticket
Avoid too many return
statements within this method. Open
return true;
- Create a ticketCreate a ticket
Avoid too many return
statements within this method. Open
return false;
- Create a ticketCreate a ticket
The method voteOnAttribute() has an NPath complexity of 288. The configured NPath complexity threshold is 200. Open
protected function voteOnAttribute($attribute, $subject, TokenInterface $token)
{
if ($this->isSuperAdmin($token)) {
return true;
}
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method voteOnAttribute() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10. Open
protected function voteOnAttribute($attribute, $subject, TokenInterface $token)
{
if ($this->isSuperAdmin($token)) {
return true;
}
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Avoid unused parameters such as '$attribute'. Open
protected function voteOnAttribute($attribute, $subject, TokenInterface $token)
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Call to method getSiteId
from undeclared class \OpenOrchestra\ModelInterface\Model\RedirectionInterface
Open
return $this->canActOnSite($subject->getSiteId(), $user);
- Create a ticketCreate a ticket
- Exclude checks
Reference to constant ENTITY_TYPE
from undeclared class \OpenOrchestra\UserBundle\Model\UserInterface
Open
UserInterface::ENTITY_TYPE,
- Create a ticketCreate a ticket
- Exclude checks
Parameter $user
has undeclared type \OpenOrchestra\UserBundle\Model\UserInterface
Open
protected function canActOnSite($siteId, UserInterface $user)
- Create a ticketCreate a ticket
- Exclude checks
Checking instanceof against undeclared class \OpenOrchestra\UserBundle\Model\UserInterface
Open
if ($subject instanceof UserInterface) {
- Create a ticketCreate a ticket
- Exclude checks
Call to method getSiteId
from undeclared class \OpenOrchestra\ModelInterface\Model\ReadSiteInterface
Open
return $this->canActOnSite($subject->getSite()->getSiteId(), $user);
- Create a ticketCreate a ticket
- Exclude checks
Reference to constant ENTITY_TYPE
from undeclared class \OpenOrchestra\ModelInterface\Model\BlockInterface
Open
BlockInterface::ENTITY_TYPE,
- Create a ticketCreate a ticket
- Exclude checks
Call to method getUser
from undeclared class \Symfony\Component\Security\Core\Authentication\Token\TokenInterface
Open
$user = $token->getUser();
- Create a ticketCreate a ticket
- Exclude checks
Checking instanceof against undeclared class \OpenOrchestra\ModelInterface\Model\RedirectionInterface
Open
if ($subject instanceof RedirectionInterface
- Create a ticketCreate a ticket
- Exclude checks
Parameter $token
has undeclared type \Symfony\Component\Security\Core\Authentication\Token\TokenInterface
Open
protected function voteOnAttribute($attribute, $subject, TokenInterface $token)
- Create a ticketCreate a ticket
- Exclude checks
Reference to constant ENTITY_TYPE
from undeclared class \OpenOrchestra\ModelInterface\Model\SiteInterface
Open
return $this->isSubjectInPerimeter($siteId, $user, SiteInterface::ENTITY_TYPE);
- Create a ticketCreate a ticket
- Exclude checks
Checking instanceof against undeclared class \OpenOrchestra\ModelInterface\Model\SiteInterface
Open
|| $subject instanceof SiteInterface
- Create a ticketCreate a ticket
- Exclude checks
Call to method getGroups
from undeclared class \OpenOrchestra\UserBundle\Model\UserInterface
Open
foreach ($subject->getGroups() as $group) {
- Create a ticketCreate a ticket
- Exclude checks
Parameter $subject
has undeclared type \OpenOrchestra\UserBundle\Model\UserInterface
Open
protected function voteForUser(UserInterface $subject, UserInterface $user)
- Create a ticketCreate a ticket
- Exclude checks
Reference to constant ENTITY_TYPE
from undeclared class \OpenOrchestra\ModelInterface\Model\RedirectionInterface
Open
RedirectionInterface::ENTITY_TYPE,
- Create a ticketCreate a ticket
- Exclude checks
Checking instanceof against undeclared class \OpenOrchestra\ModelInterface\Model\BlockInterface
Open
|| $subject instanceof BlockInterface
- Create a ticketCreate a ticket
- Exclude checks
Parameter $user
has undeclared type \OpenOrchestra\UserBundle\Model\UserInterface
Open
protected function voteForUser(UserInterface $subject, UserInterface $user)
- Create a ticketCreate a ticket
- Exclude checks
Reference to constant ENTITY_TYPE
from undeclared class \OpenOrchestra\ModelInterface\Model\SiteInterface
Open
SiteInterface::ENTITY_TYPE,
- Create a ticketCreate a ticket
- Exclude checks