Function validateCondition
has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
public function validateCondition($condition)
{
$is_boolean = true;
if (!empty($condition)) {
$encapsuledElements = array();
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The method validateCondition() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10. Open
public function validateCondition($condition)
{
$is_boolean = true;
if (!empty($condition)) {
$encapsuledElements = array();
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method validateCondition uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$is_boolean = (preg_match(KeywordableTraitInterface::IS_AND_BOOLEAN, $condition) ||
preg_match(KeywordableTraitInterface::IS_OR_BOOLEAN, $condition)) &&
$is_boolean;
}
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Reference to constant IS_OR_BOOLEAN
from undeclared class \OpenOrchestra\ModelInterface\Repository\RepositoryTrait\KeywordableTraitInterface
Open
preg_match(KeywordableTraitInterface::IS_OR_BOOLEAN, $condition)) &&
- Create a ticketCreate a ticket
- Exclude checks
Reference to constant IS_OR_BOOLEAN
from undeclared class \OpenOrchestra\ModelInterface\Repository\RepositoryTrait\KeywordableTraitInterface
Open
preg_match(KeywordableTraitInterface::IS_OR_BOOLEAN, $encapsuledElements[1][$key])) &&
- Create a ticketCreate a ticket
- Exclude checks
Reference to instance property message
from undeclared class \Symfony\Component\Validator\Constraint
Open
$this->context->buildViolation($constraint->message)
- Create a ticketCreate a ticket
- Exclude checks
Class extends undeclared class \Symfony\Component\Validator\ConstraintValidator
Open
class BooleanConditionValidator extends ConstraintValidator
- Create a ticketCreate a ticket
- Exclude checks
Reference to constant GET_BALANCED_BRACKETS
from undeclared class \OpenOrchestra\ModelInterface\Repository\RepositoryTrait\KeywordableTraitInterface
Open
KeywordableTraitInterface::GET_BALANCED_BRACKETS,
- Create a ticketCreate a ticket
- Exclude checks
Reference to constant IS_AND_BOOLEAN
from undeclared class \OpenOrchestra\ModelInterface\Repository\RepositoryTrait\KeywordableTraitInterface
Open
$is_boolean = (preg_match(KeywordableTraitInterface::IS_AND_BOOLEAN, $encapsuledElements[1][$key]) ||
- Create a ticketCreate a ticket
- Exclude checks
Reference to constant IS_AND_BOOLEAN
from undeclared class \OpenOrchestra\ModelInterface\Repository\RepositoryTrait\KeywordableTraitInterface
Open
$is_boolean = (preg_match(KeywordableTraitInterface::IS_AND_BOOLEAN, $condition) ||
- Create a ticketCreate a ticket
- Exclude checks
Parameter $constraint
has undeclared type \Symfony\Component\Validator\Constraint
Open
public function validate($value, Constraint $constraint)
- Create a ticketCreate a ticket
- Exclude checks
Reference to undeclared property \OpenOrchestra\Backoffice\Validator\Constraints\BooleanConditionValidator->context
Open
$this->context->buildViolation($constraint->message)
- Create a ticketCreate a ticket
- Exclude checks
Saw an @param annotation for columnWidth,
but it was not found in the param list of function validateCondition($condition) : bool
Open
* @param string $columnWidth
- Create a ticketCreate a ticket
- Exclude checks
Line exceeds 120 characters; contains 121 characters Open
$is_boolean = (preg_match(KeywordableTraitInterface::IS_AND_BOOLEAN, $encapsuledElements[1][$key]) ||
- Create a ticketCreate a ticket
- Exclude checks
The variable $is_boolean is not named in camelCase. Open
public function validateCondition($condition)
{
$is_boolean = true;
if (!empty($condition)) {
$encapsuledElements = array();
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $is_boolean is not named in camelCase. Open
public function validateCondition($condition)
{
$is_boolean = true;
if (!empty($condition)) {
$encapsuledElements = array();
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $is_boolean is not named in camelCase. Open
public function validateCondition($condition)
{
$is_boolean = true;
if (!empty($condition)) {
$encapsuledElements = array();
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $is_boolean is not named in camelCase. Open
public function validateCondition($condition)
{
$is_boolean = true;
if (!empty($condition)) {
$encapsuledElements = array();
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $is_boolean is not named in camelCase. Open
public function validateCondition($condition)
{
$is_boolean = true;
if (!empty($condition)) {
$encapsuledElements = array();
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $is_boolean is not named in camelCase. Open
public function validateCondition($condition)
{
$is_boolean = true;
if (!empty($condition)) {
$encapsuledElements = array();
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $is_boolean is not named in camelCase. Open
public function validateCondition($condition)
{
$is_boolean = true;
if (!empty($condition)) {
$encapsuledElements = array();
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $is_boolean is not named in camelCase. Open
public function validateCondition($condition)
{
$is_boolean = true;
if (!empty($condition)) {
$encapsuledElements = array();
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}