Sign upLogin

open-orchestra/open-orchestra-cms-bundle

View on GitHub
Star
GroupBundle/Tests/Form/DataTransformer/GroupRoleTransformerTest.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method setUp has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function setUp()
    {
        $configuration = array(
            'open_orchestra_backoffice.role.contribution' => array(
                'firstpackage' => array(
Severity: Minor
Found in GroupBundle/Tests/Form/DataTransformer/GroupRoleTransformerTest.php - About 1 hr to fix

Reference to undeclared property \OpenOrchestra\Backoffice\Tests\Form\DataTransformer\GroupRoleTransformerTest->transformer
Open

        $result = $this->transformer->reverseTransform($values);
Severity: Minor
Found in GroupBundle/Tests/Form/DataTransformer/GroupRoleTransformerTest.php by phan

Class extends undeclared class \OpenOrchestra\BaseBundle\Tests\AbstractTest\AbstractBaseTestCase
Open

class GroupRoleTransformerTest extends AbstractBaseTestCase
Severity: Critical
Found in GroupBundle/Tests/Form/DataTransformer/GroupRoleTransformerTest.php by phan

Call to undeclared method \OpenOrchestra\Backoffice\Tests\Form\DataTransformer\GroupRoleTransformerTest::assertEquals
Open

        $this->assertEquals($expectedResults, $result);
Severity: Critical
Found in GroupBundle/Tests/Form/DataTransformer/GroupRoleTransformerTest.php by phan

Reference to undeclared property \OpenOrchestra\Backoffice\Tests\Form\DataTransformer\GroupRoleTransformerTest->transformer
Open

        $result = $this->transformer->transform($values);
Severity: Minor
Found in GroupBundle/Tests/Form/DataTransformer/GroupRoleTransformerTest.php by phan

Call to undeclared method \OpenOrchestra\Backoffice\Tests\Form\DataTransformer\GroupRoleTransformerTest::assertInstanceOf
Open

        $this->assertInstanceOf('Symfony\Component\Form\DataTransformerInterface', $this->transformer);
Severity: Critical
Found in GroupBundle/Tests/Form/DataTransformer/GroupRoleTransformerTest.php by phan

Reference to undeclared property \OpenOrchestra\Backoffice\Tests\Form\DataTransformer\GroupRoleTransformerTest->transformer
Open

        $this->transformer = new GroupRoleTransformer($configuration);
Severity: Minor
Found in GroupBundle/Tests/Form/DataTransformer/GroupRoleTransformerTest.php by phan

Reference to undeclared property \OpenOrchestra\Backoffice\Tests\Form\DataTransformer\GroupRoleTransformerTest->transformer
Open

        $this->assertInstanceOf('Symfony\Component\Form\DataTransformerInterface', $this->transformer);
Severity: Minor
Found in GroupBundle/Tests/Form/DataTransformer/GroupRoleTransformerTest.php by phan

Call to undeclared method \OpenOrchestra\Backoffice\Tests\Form\DataTransformer\GroupRoleTransformerTest::assertEquals
Open

        $this->assertEquals($expectedResults, $result);
Severity: Critical
Found in GroupBundle/Tests/Form/DataTransformer/GroupRoleTransformerTest.php by phan

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        $configuration = array(
            'open_orchestra_backoffice.role.contribution' => array(
                'firstpackage' => array(
                    'page' => array(
                        'EDITORIAL_NODE_CONTRIBUTOR' => array(
Severity: Major
Found in GroupBundle/Tests/Form/DataTransformer/GroupRoleTransformerTest.php and 1 other location - About 2 hrs to fix
GroupBundle/Tests/Form/Type/GroupRoleTypeTest.php on lines 26..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 122.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid excessively long variable names like $generatePerimeterManager. Keep variable name length under 20.
Open

    protected $generatePerimeterManager;
Severity: Minor
Found in GroupBundle/Tests/Form/DataTransformer/GroupRoleTransformerTest.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Line exceeds 120 characters; contains 138 characters
Open

            array(array('EDITORIAL_NODE_CONTRIBUTOR', 'EDITORIAL_TRASH_SUPRESSOR', 'ROLE_SITE_ADMIN'), array('roles_collections' => array(
Severity: Minor
Found in GroupBundle/Tests/Form/DataTransformer/GroupRoleTransformerTest.php by phpcodesniffer

There are no issues that match your filters.

Category
Status