Sign upLogin

open-orchestra/open-orchestra-cms-bundle

View on GitHub
Star
LogBundle/EventSubscriber/LogSiteSubscriber.php

Summary

Maintainability
B
4 hrs
Test Coverage

Parameter $event has undeclared type \OpenOrchestra\ModelInterface\Event\SiteEvent
Open

    public function siteCreate(SiteEvent $event)
Severity: Minor
Found in LogBundle/EventSubscriber/LogSiteSubscriber.php by phan

Reference to constant SITE_DELETE from undeclared class \OpenOrchestra\ModelInterface\SiteEvents
Open

            SiteEvents::SITE_DELETE => 'siteDelete',
Severity: Critical
Found in LogBundle/EventSubscriber/LogSiteSubscriber.php by phan

Parameter $event has undeclared type \OpenOrchestra\ModelInterface\Event\SiteEvent
Open

    public function siteUpdate(SiteEvent $event)
Severity: Minor
Found in LogBundle/EventSubscriber/LogSiteSubscriber.php by phan

Call to method getSite from undeclared class \OpenOrchestra\ModelInterface\Event\SiteEvent
Open

        $this->sendLog('open_orchestra_log.site.update', $event->getSite());
Severity: Critical
Found in LogBundle/EventSubscriber/LogSiteSubscriber.php by phan

Parameter $event has undeclared type \OpenOrchestra\ModelInterface\Event\SiteEvent
Open

    public function siteDelete(SiteEvent $event)
Severity: Minor
Found in LogBundle/EventSubscriber/LogSiteSubscriber.php by phan

Parameter $site has undeclared type \OpenOrchestra\ModelInterface\Model\SiteInterface
Open

    protected function sendLog($message, SiteInterface $site)
Severity: Minor
Found in LogBundle/EventSubscriber/LogSiteSubscriber.php by phan

Reference to constant SITE_UPDATE from undeclared class \OpenOrchestra\ModelInterface\SiteEvents
Open

            SiteEvents::SITE_UPDATE => 'siteUpdate',
Severity: Critical
Found in LogBundle/EventSubscriber/LogSiteSubscriber.php by phan

Reference to constant SITE_CREATE from undeclared class \OpenOrchestra\ModelInterface\SiteEvents
Open

            SiteEvents::SITE_CREATE => 'siteCreate',
Severity: Critical
Found in LogBundle/EventSubscriber/LogSiteSubscriber.php by phan

Call to method getSiteId from undeclared class \OpenOrchestra\ModelInterface\Model\SiteInterface
Open

            'site_id' => $site->getSiteId(),
Severity: Critical
Found in LogBundle/EventSubscriber/LogSiteSubscriber.php by phan

Call to method getName from undeclared class \OpenOrchestra\ModelInterface\Model\SiteInterface
Open

            'site_name' => $site->getName()
Severity: Critical
Found in LogBundle/EventSubscriber/LogSiteSubscriber.php by phan

Call to method getSite from undeclared class \OpenOrchestra\ModelInterface\Event\SiteEvent
Open

        $this->sendLog('open_orchestra_log.site.create', $event->getSite());
Severity: Critical
Found in LogBundle/EventSubscriber/LogSiteSubscriber.php by phan

Call to method getSite from undeclared class \OpenOrchestra\ModelInterface\Event\SiteEvent
Open

        $this->sendLog('open_orchestra_log.site.delete', $event->getSite());
Severity: Critical
Found in LogBundle/EventSubscriber/LogSiteSubscriber.php by phan

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

namespace OpenOrchestra\LogBundle\EventSubscriber;

use OpenOrchestra\ModelInterface\Event\SiteEvent;
Severity: Major
Found in LogBundle/EventSubscriber/LogSiteSubscriber.php and 1 other location - About 4 hrs to fix
LogBundle/EventSubscriber/LogRedirectionSubscriber.php on lines 1..61

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 169.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status