Sign upLogin

open-orchestra/open-orchestra-cms-bundle

View on GitHub
Star
LogBundle/EventSubscriber/LogStatusSubscriber.php

Summary

Maintainability
A
3 hrs
Test Coverage

Call to method getStatus from undeclared class \OpenOrchestra\ModelInterface\Event\StatusEvent
Open

        $this->sendLog('open_orchestra_log.status.update', $event->getStatus());
Severity: Critical
Found in LogBundle/EventSubscriber/LogStatusSubscriber.php by phan

Call to method getStatus from undeclared class \OpenOrchestra\ModelInterface\Event\StatusEvent
Open

        $this->sendLog('open_orchestra_log.status.create', $event->getStatus());
Severity: Critical
Found in LogBundle/EventSubscriber/LogStatusSubscriber.php by phan

Parameter $event has undeclared type \OpenOrchestra\ModelInterface\Event\StatusEvent
Open

    public function statusCreate(StatusEvent $event)
Severity: Minor
Found in LogBundle/EventSubscriber/LogStatusSubscriber.php by phan

Call to method getStatus from undeclared class \OpenOrchestra\ModelInterface\Event\StatusEvent
Open

        $this->sendLog('open_orchestra_log.status.delete', $event->getStatus());
Severity: Critical
Found in LogBundle/EventSubscriber/LogStatusSubscriber.php by phan

Parameter $event has undeclared type \OpenOrchestra\ModelInterface\Event\StatusEvent
Open

    public function statusDelete(StatusEvent $event)
Severity: Minor
Found in LogBundle/EventSubscriber/LogStatusSubscriber.php by phan

Parameter $event has undeclared type \OpenOrchestra\ModelInterface\Event\StatusEvent
Open

    public function statusUpdate(StatusEvent $event)
Severity: Minor
Found in LogBundle/EventSubscriber/LogStatusSubscriber.php by phan

Reference to constant STATUS_UPDATE from undeclared class \OpenOrchestra\ModelInterface\StatusEvents
Open

            StatusEvents::STATUS_UPDATE => 'statusUpdate',
Severity: Critical
Found in LogBundle/EventSubscriber/LogStatusSubscriber.php by phan

Call to method getName from undeclared class \OpenOrchestra\ModelInterface\Model\StatusInterface
Open

        $this->logger->info($message, array('status_name' => $status->getName()));
Severity: Critical
Found in LogBundle/EventSubscriber/LogStatusSubscriber.php by phan

Parameter $status has undeclared type \OpenOrchestra\ModelInterface\Model\StatusInterface
Open

    protected function sendLog($message, StatusInterface $status)
Severity: Minor
Found in LogBundle/EventSubscriber/LogStatusSubscriber.php by phan

Reference to constant STATUS_CREATE from undeclared class \OpenOrchestra\ModelInterface\StatusEvents
Open

            StatusEvents::STATUS_CREATE => 'statusCreate',
Severity: Critical
Found in LogBundle/EventSubscriber/LogStatusSubscriber.php by phan

Reference to constant STATUS_DELETE from undeclared class \OpenOrchestra\ModelInterface\StatusEvents
Open

            StatusEvents::STATUS_DELETE => 'statusDelete',
Severity: Critical
Found in LogBundle/EventSubscriber/LogStatusSubscriber.php by phan

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

namespace OpenOrchestra\LogBundle\EventSubscriber;

use OpenOrchestra\ModelInterface\Event\StatusEvent;
Severity: Major
Found in LogBundle/EventSubscriber/LogStatusSubscriber.php and 1 other location - About 3 hrs to fix
LogBundle/EventSubscriber/LogGroupSubscriber.php on lines 1..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 161.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status