open-orchestra/open-orchestra-cms-bundle

View on GitHub
LogBundle/Tests/EventSubscriber/LogStatusSubscriberTest.php

Summary

Maintainability
C
1 day
Test Coverage

Avoid using static access to class '\Phake' in method 'setUp'.
Open

        $this->status = Phake::mock('OpenOrchestra\ModelInterface\Model\StatusInterface');

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'setUp'.
Open

        $this->statusEvent = Phake::mock('OpenOrchestra\ModelInterface\Event\StatusEvent');

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Call to method mock from undeclared class \Phake
Open

        $this->statusEvent = Phake::mock('OpenOrchestra\ModelInterface\Event\StatusEvent');

Reference to constant STATUS_DELETE from undeclared class \OpenOrchestra\ModelInterface\StatusEvents
Open

            array(StatusEvents::STATUS_DELETE),

Call to method when from undeclared class \Phake
Open

        Phake::when($this->statusEvent)->getStatus()->thenReturn($this->status);

Call to method mock from undeclared class \Phake
Open

        $this->status = Phake::mock('OpenOrchestra\ModelInterface\Model\StatusInterface');

Reference to constant STATUS_UPDATE from undeclared class \OpenOrchestra\ModelInterface\StatusEvents
Open

            array(StatusEvents::STATUS_UPDATE),

Reference to constant STATUS_CREATE from undeclared class \OpenOrchestra\ModelInterface\StatusEvents
Open

            array(StatusEvents::STATUS_CREATE),

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

namespace OpenOrchestra\LogBundle\Tests\EventSubscriber;

use Phake;
Severity: Major
Found in LogBundle/Tests/EventSubscriber/LogStatusSubscriberTest.php and 1 other location - About 1 day to fix
LogBundle/Tests/EventSubscriber/LogGroupSubscriberTest.php on lines 1..68

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 263.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status