Sign upLogin

open-orchestra/open-orchestra-cms-bundle

View on GitHub
Star
UserAdminBundle/Transformer/UserTransformer.php

Summary

Maintainability
A
35 mins
Test Coverage

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        $facadeClass,
        AuthorizationCheckerInterface $authorizationChecker,
        EventDispatcherInterface $eventDispatcher,
        MultiLanguagesChoiceManagerInterface $multiLanguagesChoiceManager,
        UserRepositoryInterface $userRepository
Severity: Minor
Found in UserAdminBundle/Transformer/UserTransformer.php - About 35 mins to fix

Avoid unused parameters such as '$params'.
Open

    public function reverseTransform(FacadeInterface $facade, array $params = array())
Severity: Minor
Found in UserAdminBundle/Transformer/UserTransformer.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$params'.
Open

    public function transform($user, array $params = array())
Severity: Minor
Found in UserAdminBundle/Transformer/UserTransformer.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Return type of transform() is undeclared type \OpenOrchestra\BaseApi\Facade\FacadeInterface
Open

    public function transform($user, array $params = array())
Severity: Minor
Found in UserAdminBundle/Transformer/UserTransformer.php by phan

@throws type of transform has undeclared type \OpenOrchestra\BaseApi\Exceptions\TransformerParameterTypeException
Open

    public function transform($user, array $params = array())
Severity: Minor
Found in UserAdminBundle/Transformer/UserTransformer.php by phan

Reference to instance property id from undeclared class \OpenOrchestra\BaseApi\Facade\FacadeInterface
Open

            return $this->userRepository->find($facade->id);
Severity: Minor
Found in UserAdminBundle/Transformer/UserTransformer.php by phan

Call to method getGroups from undeclared class \OpenOrchestra\UserBundle\Model\UserInterface
Open

        $groups = $user->getGroups();
Severity: Critical
Found in UserAdminBundle/Transformer/UserTransformer.php by phan

Call to method getId from undeclared class \OpenOrchestra\UserBundle\Model\UserInterface
Open

        $facade->id = $user->getId();
Severity: Critical
Found in UserAdminBundle/Transformer/UserTransformer.php by phan

Parameter $eventDispatcher has undeclared type \Symfony\Component\EventDispatcher\EventDispatcherInterface
Open

    public function __construct(
Severity: Minor
Found in UserAdminBundle/Transformer/UserTransformer.php by phan

Call to undeclared method \OpenOrchestra\UserAdminBundle\Transformer\UserTransformer::newFacade
Open

        $facade = $this->newFacade();
Severity: Critical
Found in UserAdminBundle/Transformer/UserTransformer.php by phan

Reference to undeclared property \OpenOrchestra\UserAdminBundle\Transformer\UserTransformer->authorizationChecker
Open

            $canDelete = $this->authorizationChecker->isGranted(ContributionActionInterface::DELETE, $user);
Severity: Minor
Found in UserAdminBundle/Transformer/UserTransformer.php by phan

Return type of reverseTransform() is undeclared type \OpenOrchestra\UserBundle\Model\UserInterface
Open

    public function reverseTransform(FacadeInterface $facade, array $params = array())
Severity: Minor
Found in UserAdminBundle/Transformer/UserTransformer.php by phan

Call to method __construct from undeclared class \OpenOrchestra\BaseApi\Exceptions\TransformerParameterTypeException
Open

            throw new TransformerParameterTypeException();
Severity: Critical
Found in UserAdminBundle/Transformer/UserTransformer.php by phan

Parameter $authorizationChecker has undeclared type \Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface
Open

    public function __construct(
Severity: Minor
Found in UserAdminBundle/Transformer/UserTransformer.php by phan

Reference to instance property id from undeclared class \OpenOrchestra\BaseApi\Facade\FacadeInterface
Open

        if (null !== $facade->id) {
Severity: Minor
Found in UserAdminBundle/Transformer/UserTransformer.php by phan

Call to method getRoles from undeclared class \OpenOrchestra\UserBundle\Model\UserInterface
Open

        $facade->roles = implode(',', $user->getRoles());
Severity: Critical
Found in UserAdminBundle/Transformer/UserTransformer.php by phan

Call to method choose from undeclared class \OpenOrchestra\ModelInterface\Manager\MultiLanguagesChoiceManagerInterface
Open

                $labels[] = $this->multiLanguagesChoiceManager->choose($group->getLabels());
Severity: Critical
Found in UserAdminBundle/Transformer/UserTransformer.php by phan

Parameter $multiLanguagesChoiceManager has undeclared type \OpenOrchestra\ModelInterface\Manager\MultiLanguagesChoiceManagerInterface
Open

    public function __construct(
Severity: Minor
Found in UserAdminBundle/Transformer/UserTransformer.php by phan

Parameter $user has undeclared type \OpenOrchestra\UserBundle\Model\UserInterface
Open

    public function transform($user, array $params = array())
Severity: Minor
Found in UserAdminBundle/Transformer/UserTransformer.php by phan

Checking instanceof against undeclared class \OpenOrchestra\UserBundle\Model\UserInterface
Open

        if (!$user instanceof UserInterface) {
Severity: Critical
Found in UserAdminBundle/Transformer/UserTransformer.php by phan

Call to method getUsername from undeclared class \OpenOrchestra\UserBundle\Model\UserInterface
Open

        $facade->username = $user->getUsername();
Severity: Critical
Found in UserAdminBundle/Transformer/UserTransformer.php by phan

Call to method getEmail from undeclared class \OpenOrchestra\UserBundle\Model\UserInterface
Open

        $facade->email = $user->getEmail();
Severity: Critical
Found in UserAdminBundle/Transformer/UserTransformer.php by phan

Parameter $userRepository has undeclared type \OpenOrchestra\UserBundle\Repository\UserRepositoryInterface
Open

    public function __construct(
Severity: Minor
Found in UserAdminBundle/Transformer/UserTransformer.php by phan

Call to method find from undeclared class \OpenOrchestra\UserBundle\Repository\UserRepositoryInterface
Open

            return $this->userRepository->find($facade->id);
Severity: Critical
Found in UserAdminBundle/Transformer/UserTransformer.php by phan

Parameter $facade has undeclared type \OpenOrchestra\BaseApi\Facade\FacadeInterface
Open

    public function reverseTransform(FacadeInterface $facade, array $params = array())
Severity: Minor
Found in UserAdminBundle/Transformer/UserTransformer.php by phan

Class extends undeclared class \OpenOrchestra\BaseApi\Transformer\AbstractSecurityCheckerAwareTransformer
Open

class UserTransformer extends AbstractSecurityCheckerAwareTransformer
Severity: Critical
Found in UserAdminBundle/Transformer/UserTransformer.php by phan

Reference to undeclared class \OpenOrchestra\BaseApi\Transformer\AbstractSecurityCheckerAwareTransformer
Open

        parent::__construct($facadeClass, $authorizationChecker);
Severity: Critical
Found in UserAdminBundle/Transformer/UserTransformer.php by phan

Call to undeclared method \OpenOrchestra\UserAdminBundle\Transformer\UserTransformer::hasGroup
Open

        if ($this->hasGroup(CMSGroupContext::AUTHORIZATIONS)) {
Severity: Critical
Found in UserAdminBundle/Transformer/UserTransformer.php by phan

Avoid excessively long variable names like $multiLanguagesChoiceManager. Keep variable name length under 20.
Open

    protected $multiLanguagesChoiceManager;
Severity: Minor
Found in UserAdminBundle/Transformer/UserTransformer.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $multiLanguagesChoiceManager. Keep variable name length under 20.
Open

        MultiLanguagesChoiceManagerInterface $multiLanguagesChoiceManager,
Severity: Minor
Found in UserAdminBundle/Transformer/UserTransformer.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

The closing brace for the class must go on the next line after the body
Open

}
Severity: Minor
Found in UserAdminBundle/Transformer/UserTransformer.php by phpcodesniffer

Expected 1 space after closing parenthesis; found 0
Open

        foreach($groups as $group){
Severity: Minor
Found in UserAdminBundle/Transformer/UserTransformer.php by phpcodesniffer

Expected 1 space after FOREACH keyword; 0 found
Open

        foreach($groups as $group){
Severity: Minor
Found in UserAdminBundle/Transformer/UserTransformer.php by phpcodesniffer

There are no issues that match your filters.

Category
Status