open-orchestra/open-orchestra-cms-bundle

View on GitHub
Workflow/Validator/Constraints/WorkflowParameterValidator.php

Summary

Maintainability
A
3 hrs
Test Coverage

Function validate has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public function validate($value, Constraint $constraint)
    {
        $parameters = array(
            'initial_state' => 0,
            'translation_state' => 0,
Severity: Minor
Found in Workflow/Validator/Constraints/WorkflowParameterValidator.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validate has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function validate($value, Constraint $constraint)
    {
        $parameters = array(
            'initial_state' => 0,
            'translation_state' => 0,
Severity: Minor
Found in Workflow/Validator/Constraints/WorkflowParameterValidator.php - About 1 hr to fix

The method validate() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
Open

    public function validate($value, Constraint $constraint)
    {
        $parameters = array(
            'initial_state' => 0,
            'translation_state' => 0,

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

Reference to undeclared property \OpenOrchestra\Workflow\Validator\Constraints\WorkflowParameterValidator->context
Open

                $this->context

Reference to instance property requiredParameterMessage from undeclared class \Symfony\Component\Validator\Constraint
Open

                    ->buildViolation($constraint->requiredParameterMessage)

Call to method trans from undeclared class \Symfony\Component\Translation\TranslatorInterface
Open

                $label = $this->translator

Class extends undeclared class \Symfony\Component\Validator\ConstraintValidator
Open

class WorkflowParameterValidator extends ConstraintValidator

Parameter $translator has undeclared type \Symfony\Component\Translation\TranslatorInterface
Open

    public function __construct(TranslatorInterface $translator)

Reference to undeclared property \OpenOrchestra\Workflow\Validator\Constraints\WorkflowParameterValidator->context
Open

                $this->context

Reference to instance property uniqueParameterMessage from undeclared class \Symfony\Component\Validator\Constraint
Open

                    ->buildViolation($constraint->uniqueParameterMessage)

Call to method trans from undeclared class \Symfony\Component\Translation\TranslatorInterface
Open

                $label = $this->translator

Parameter $constraint has undeclared type \Symfony\Component\Validator\Constraint
Open

    public function validate($value, Constraint $constraint)

There are no issues that match your filters.

Category
Status