open-orchestra/open-orchestra-cms-bundle

View on GitHub
WorkflowAdminBundle/Transformer/WorkflowProfileCollectionTransformer.php

Summary

Maintainability
A
3 hrs
Test Coverage

Avoid unused parameters such as '$params'.
Open

    public function reverseTransform(FacadeInterface $facade, array $params = array())

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$params'.
Open

    public function transform($workflowProfileCollection, array $params = array())

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Returning type array<int>|array{}</int> but reverseTransform() is declared to return \OpenOrchestra\ModelInterface\Model\WorkflowProfileInterface|null
Open

        return $workflowProfiles;

Call to undeclared method \OpenOrchestra\WorkflowAdminBundle\Transformer\WorkflowProfileCollectionTransformer::newFacade
Open

        $facade = $this->newFacade();

Call to undeclared method \OpenOrchestra\WorkflowAdminBundle\Transformer\WorkflowProfileCollectionTransformer::getContext
Open

            $facade->addWorkflowProfile($this->getContext()->transform('workflow_profile', $workflowProfile));

Class extends undeclared class \OpenOrchestra\BaseApi\Transformer\AbstractTransformer
Open

class WorkflowProfileCollectionTransformer extends AbstractTransformer

Parameter $workflowProfileCollection has undeclared type \Doctrine\Common\Collections\Collection
Open

    public function transform($workflowProfileCollection, array $params = array())

Return type of transform() is undeclared type \OpenOrchestra\BaseApi\Facade\FacadeInterface
Open

    public function transform($workflowProfileCollection, array $params = array())

Parameter $facade has undeclared type \OpenOrchestra\BaseApi\Facade\FacadeInterface
Open

    public function reverseTransform(FacadeInterface $facade, array $params = array())

Return type of reverseTransform() is undeclared type \OpenOrchestra\ModelInterface\Model\WorkflowProfileInterface
Open

    public function reverseTransform(FacadeInterface $facade, array $params = array())

Call to undeclared method \OpenOrchestra\WorkflowAdminBundle\Transformer\WorkflowProfileCollectionTransformer::getContext
Open

            $workflowProfile = $this->getContext()->reverseTransform('workflow_profile', $workflowProfileFacade);

Call to method getWorkflowProfiles from undeclared class \OpenOrchestra\BaseApi\Facade\FacadeInterface
Open

        $workflowProfilesFacade = $facade->getWorkflowProfiles();

Similar blocks of code found in 8 locations. Consider refactoring.
Open

<?php

namespace OpenOrchestra\WorkflowAdminBundle\Transformer;

use Doctrine\Common\Collections\Collection;
ApiBundle/Transformer/ContentCollectionTransformer.php on lines 1..58
ApiBundle/Transformer/ContentTypeCollectionTransformer.php on lines 1..60
ApiBundle/Transformer/KeywordCollectionTransformer.php on lines 1..58
ApiBundle/Transformer/NodeCollectionTransformer.php on lines 1..62
ApiBundle/Transformer/RedirectionCollectionTransformer.php on lines 1..59
ApiBundle/Transformer/TrashItemCollectionTransformer.php on lines 1..58
UserAdminBundle/Transformer/UserCollectionTransformer.php on lines 1..59

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 160.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid excessively long variable names like $workflowProfilesFacade. Keep variable name length under 20.
Open

        $workflowProfilesFacade = $facade->getWorkflowProfiles();

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $workflowProfileCollection. Keep variable name length under 20.
Open

    public function transform($workflowProfileCollection, array $params = array())

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $workflowProfileFacade. Keep variable name length under 20.
Open

        foreach ($workflowProfilesFacade as $workflowProfileFacade) {

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

The closing brace for the class must go on the next line after the body
Open

}

There are no issues that match your filters.

Category
Status