openSNP/snpr

View on GitHub
app/controllers/users_controller.rb

Summary

Maintainability
B
5 hrs
Test Coverage
D
68%

Method update has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

  def update
    @user = User.find(params[:id])

    if params[:user][:user_phenotypes_attributes].present?
      params[:user][:user_phenotypes_attributes].each do |p|
Severity: Minor
Found in app/controllers/users_controller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method show has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def show
    # showing a single user's page
    @user = User.find_by_id(params[:id]) || not_found
    @title = @user.name + '\'s page'
    @first_name = @user.name.split.first
Severity: Minor
Found in app/controllers/users_controller.rb - About 1 hr to fix

    Method index has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def index
        # showing all users
        # TODO: Refactor this. - Helge
        @users = User.order(sort_column + ' ' + sort_direction)
        @users_paginate = @users.paginate(page: params[:page], per_page: 10)
    Severity: Minor
    Found in app/controllers/users_controller.rb - About 1 hr to fix

      Method update has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def update
          @user = User.find(params[:id])
      
          if params[:user][:user_phenotypes_attributes].present?
            params[:user][:user_phenotypes_attributes].each do |p|
      Severity: Minor
      Found in app/controllers/users_controller.rb - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status