Sign upLogin

openSNP/snpr

View on GitHub
Star
app/workers/preparsing.rb

Summary

Maintainability
C
1 day
Test Coverage

Method perform has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

  def perform(genotype_id)
    genotype = Genotype.find(genotype_id)

    logger.info "Starting preparse"
    biggest = ''
Severity: Minor
Found in app/workers/preparsing.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method perform has 104 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def perform(genotype_id)
    genotype = Genotype.find(genotype_id)

    logger.info "Starting preparse"
    biggest = ''
Severity: Major
Found in app/workers/preparsing.rb - About 4 hrs to fix

    Avoid deeply nested control flow statements.
    Open

          if l.strip.split(",").length == 6
        file_is_ok = true
        logger.info "file is decodeme and is ok!"
      end
    Severity: Major
    Found in app/workers/preparsing.rb - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

          elsif genotype.filetype == "ftdna-illumina"
      # first line is of length 4
      if l.strip.split(",").length == 4
        file_is_ok = true
        logger.info "file is ftdna and is ok!"
      Severity: Major
      Found in app/workers/preparsing.rb - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status