Showing 342 of 433 total issues
Method expand_receivers
has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring. Open
def expand_receivers(receivers, channel)
receivers.inject([]) do |new_receivers, receiver|
case receiver
when User
new_receivers << receiver if receiver.is_active?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method register
has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring. Open
def self.register(opts)
can_register?
opts[:note] = nil unless User.admin_session?
state = ::Configuration.registration == 'allow' ? 'confirmed' : 'unconfirmed'
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method build_maintenance_incident
has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring. Open
def self.build_maintenance_incident(project, no_access = false, request = nil)
result = nil
return result unless project && project.kind == 'maintenance'
request = { request: request } if request
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method render_main_attributes
has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring. Open
def render_main_attributes(builder, opts)
attribs.each do |attr|
next unless render?(attr, opts[:attrib_type], opts[:binary])
p = {}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method check_delete_accept
has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring. Open
def check_delete_accept(action, opts)
if @target_package
return if opts.include?(:force) && opts[:force].in?([nil, '1'])
@target_package.check_weak_dependencies!
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method check_valid_release_target!
has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring. Open
def check_valid_release_target!(target_repository, architecture_filter = nil)
# first architecture must be the same
# not using "architectures" here becasue the position is critical
unless repository_architectures.first.architecture == target_repository.repository_architectures.first.architecture
raise ArchitectureOrderMissmatch, "Repository '#{name}' and releasetarget " \
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method render_body
has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring. Open
def render_body(node, change = nil)
p = {}
p[:change] = change if change
node.issue(p) do |issue|
issue.created_at(created_at)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method delete_on_backend
has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring. Open
def delete_on_backend
if CONFIG['global_write_through'] && !@commit_opts[:no_backend_write]
begin
options = { comment: @commit_opts[:comment] }
options[:user] = @commit_opts[:login] || User.session!.login
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method project_or_package_link
has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring. Open
def project_or_package_link(opts)
defaults = { package: nil, rev: nil, short: false, trim_to: 40 }
opts = defaults.merge(opts)
# only care for database entries
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method show
has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring. Open
def show
# TODO: Remove this `if` condition, and the `else` clause once request_show_redesign is rolled out
if Flipper.enabled?(:request_show_redesign, User.session)
@history_elements = @bs_request.history_elements.includes(:user)
@active_tab = 'conversation'
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method owner
has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring. Open
def owner
if params[:binary].present?
owners = OwnerSearch::Assignee.new(params).for(params[:binary])
elsif (obj = owner_group_or_user)
owners = OwnerSearch::Owned.new(params).for(obj)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method create
has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring. Open
def create
params[:project][:name] = "#{params[:namespace]}:#{params[:project][:name]}" if params[:namespace]
@project = Project.new(project_params)
authorize(@project, :create?)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method guess_code_class
has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring. Open
def guess_code_class(filename)
return 'xml' if filename.in?(%w[_aggregate _link _patchinfo _service]) || filename =~ /.*\.service/
return 'shell' if /^rc[\w-]+$/.match?(filename) # rc-scripts are shell
return 'python' if /^.*rpmlintrc$/.match?(filename)
return 'makefile' if filename == 'debian.rules'
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method buildinfo
has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring. Open
def buildinfo
required_parameters :project, :repository, :arch, :package
# just for permission checking
if request.post? && Package.striping_multibuild_suffix(params[:package]) == '_repository'
# for osc local package build in this repository
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method monitor_buildresult
has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring. Open
def monitor_buildresult
@legend = Buildresult::STATUS_DESCRIPTION
@name_filter = params[:pkgname]
@lastbuild_switch = params[:lastbuild]
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method import_from_package
has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring. Open
def import_from_package
package = Package.find(params[:package_id])
kiwi_file = package.kiwi_image_file
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method validate_params
has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring. Open
def validate_params
params.each do |key, value|
next if value.nil?
next if key == 'xmlhash' # perfectly fine
raise InvalidParameterError, "Parameter #{key} has non String class #{value.class}" unless value.is_a?(String)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method copy_binaries_to_repository
has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring. Open
def copy_binaries_to_repository(source_repository, filter_architecture, source_package, target_repo, target_package_name,
multibuild_container, setrelease)
# get updateinfo id in case the source package comes from a maintenance project
u_id = get_updateinfo_id(source_package, target_repo)
source_package_name = source_package.name
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method package_command_instantiate
has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring. Open
def package_command_instantiate
project = Project.get_by_name(params[:project])
opackage = Package.get_by_project_and_name(project.name, params[:package], check_update_project: true)
raise RemoteProjectError, 'Instantiation from remote project is not supported' unless opackage
raise CmdExecutionNoPermission, 'package is already intialized here' if project == opackage.project
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method parse_one_diff
has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring. Open
def parse_one_diff(sourcediff)
# Sort files into categories by their ending and add all of them to a hash. We
# will later use the sorted and concatenated categories as key index into the per action file hash.
changes_file_keys = []
spec_file_keys = []
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"