Sign upLogin

openSUSE/open-build-service

View on GitHub
Star
src/api/app/controllers/webui/patchinfo_controller.rb

Summary

Maintainability
B
4 hrs
Test Coverage
A
98%

Method new_tracker has a Cognitive Complexity of 19 (exceeds 8 allowed). Consider refactoring.
Open

  def new_tracker
    # collection with all informations of the new issues
    issue_collection = []
    error = ''
    invalid_format = ''
Severity: Minor
Found in src/api/app/controllers/webui/patchinfo_controller.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method new_tracker has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def new_tracker
    # collection with all informations of the new issues
    issue_collection = []
    error = ''
    invalid_format = ''
Severity: Minor
Found in src/api/app/controllers/webui/patchinfo_controller.rb - About 1 hr to fix

    Method update has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
    Open

      def update
    authorize @package, :update?
    @patchinfo = Patchinfo.new(patchinfo_params)
    if @patchinfo.valid?
      xml = @patchinfo.to_xml(@project, @package)
    Severity: Minor
    Found in src/api/app/controllers/webui/patchinfo_controller.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status