openSUSE/open-build-service

View on GitHub
src/api/app/controllers/webui/project_controller.rb

Summary

Maintainability
F
3 days
Test Coverage

File project_controller.rb has 503 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class Webui::ProjectController < Webui::WebuiController
  include Webui::RequestHelper
  include Webui::ProjectHelper
  include Webui::ManageRelationships

Severity: Major
Found in src/api/app/controllers/webui/project_controller.rb - About 1 day to fix

    Class ProjectController has 43 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class Webui::ProjectController < Webui::WebuiController
      include Webui::RequestHelper
      include Webui::ProjectHelper
      include Webui::ManageRelationships
    
    
    Severity: Minor
    Found in src/api/app/controllers/webui/project_controller.rb - About 5 hrs to fix

      Method monitor_parse_result has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

        def monitor_parse_result(result)
          repo = result['repository']
          arch = result['arch']
      
          return unless @repo_filter.nil? || @repo_filter.include?(repo)
      Severity: Minor
      Found in src/api/app/controllers/webui/project_controller.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method monitor_set_filter has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

        def monitor_set_filter(defaults)
          @avail_status_values = Buildresult.avail_status_values
          @status_filter = []
          @avail_status_values.each do |s|
            id = s.delete(' ')
      Severity: Minor
      Found in src/api/app/controllers/webui/project_controller.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method filter_matches? has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def filter_matches?(input, filter_string)
          result = false
          filter_string.gsub!(/\s*/, '')
          filter_string.split(',').each do |filter|
            no_invert = filter.match(/(^!?)(.+)/)
      Severity: Minor
      Found in src/api/app/controllers/webui/project_controller.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method new_release_request has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def new_release_request
          if params[:skiprequest]
            # FIXME2.3: do it directly here, api function missing
          else
            begin
      Severity: Minor
      Found in src/api/app/controllers/webui/project_controller.rb - About 1 hr to fix

        Method create has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def create
            params[:project][:name] = "#{params[:namespace]}:#{params[:project][:name]}" if params[:namespace]
        
            @project = Project.new(project_params)
            authorize(@project, :create?)
        Severity: Minor
        Found in src/api/app/controllers/webui/project_controller.rb - About 1 hr to fix

          Method monitor_buildresult has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

            def monitor_buildresult
              @legend = Buildresult::STATUS_DESCRIPTION
          
              @name_filter = params[:pkgname]
              @lastbuild_switch = params[:lastbuild]
          Severity: Minor
          Found in src/api/app/controllers/webui/project_controller.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method create has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

            def create
              params[:project][:name] = "#{params[:namespace]}:#{params[:project][:name]}" if params[:namespace]
          
              @project = Project.new(project_params)
              authorize(@project, :create?)
          Severity: Minor
          Found in src/api/app/controllers/webui/project_controller.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            def update
              authorize @project, :update?
              respond_to do |format|
                if @project.update(project_params)
                  format.html do
          Severity: Minor
          Found in src/api/app/controllers/webui/project_controller.rb and 1 other location - About 55 mins to fix
          src/api/app/controllers/webui/package_controller.rb on lines 51..65

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status