openSUSE/open-build-service

View on GitHub
src/api/app/controllers/webui/project_controller.rb

Summary

Maintainability
D
2 days
Test Coverage

File project_controller.rb has 493 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class Webui::ProjectController < Webui::WebuiController
  require_dependency 'opensuse/validator'
  include Webui::RequestHelper
  include Webui::ProjectHelper
  include Webui::ManageRelationships
Severity: Minor
Found in src/api/app/controllers/webui/project_controller.rb - About 7 hrs to fix

    Class ProjectController has 42 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class Webui::ProjectController < Webui::WebuiController
      require_dependency 'opensuse/validator'
      include Webui::RequestHelper
      include Webui::ProjectHelper
      include Webui::ManageRelationships
    Severity: Minor
    Found in src/api/app/controllers/webui/project_controller.rb - About 5 hrs to fix

      Method monitor_parse_result has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

        def monitor_parse_result(result)
          repo = result['repository']
          arch = result['arch']
      
          return unless @repo_filter.nil? || @repo_filter.include?(repo)
      Severity: Minor
      Found in src/api/app/controllers/webui/project_controller.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method monitor_set_filter has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

        def monitor_set_filter(defaults)
          @avail_status_values = Buildresult.avail_status_values
          @status_filter = []
          @avail_status_values.each do |s|
            id = s.delete(' ')
      Severity: Minor
      Found in src/api/app/controllers/webui/project_controller.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method filter_matches? has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def filter_matches?(input, filter_string)
          result = false
          filter_string.gsub!(/\s*/, '')
          filter_string.split(',').each do |filter|
            no_invert = filter.match(/(^!?)(.+)/)
      Severity: Minor
      Found in src/api/app/controllers/webui/project_controller.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method new_release_request has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def new_release_request
          if params[:skiprequest]
            # FIXME2.3: do it directly here, api function missing
          else
            begin
      Severity: Minor
      Found in src/api/app/controllers/webui/project_controller.rb - About 1 hr to fix

        Method create has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def create
            # ns means namespace / parent project
            params[:project][:name] = "#{params[:ns]}:#{params[:project][:name]}" if params[:ns]
        
            @project = Project.new(project_params)
        Severity: Minor
        Found in src/api/app/controllers/webui/project_controller.rb - About 1 hr to fix

          Method create has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

            def create
              # ns means namespace / parent project
              params[:project][:name] = "#{params[:ns]}:#{params[:project][:name]}" if params[:ns]
          
              @project = Project.new(project_params)
          Severity: Minor
          Found in src/api/app/controllers/webui/project_controller.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method monitor_buildresult has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

            def monitor_buildresult
              @legend = Buildresult::STATUS_DESCRIPTION
          
              @name_filter = params[:pkgname]
              @lastbuild_switch = params[:lastbuild]
          Severity: Minor
          Found in src/api/app/controllers/webui/project_controller.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status