openSUSE/open-build-service

View on GitHub
src/api/app/controllers/webui/projects/status_controller.rb

Summary

Maintainability
A
0 mins
Test Coverage
F
42%

Method status_filter_packages has a Cognitive Complexity of 26 (exceeds 8 allowed). Consider refactoring.
Wontfix

      def status_filter_packages
        filter_for_user = User.find_by_login!(@filter_for_user) if @filter_for_user.present?
        current_develproject = @filter || @all_projects
        @develprojects = {}
        packages_to_filter_for = nil
Severity: Minor
Found in src/api/app/controllers/webui/projects/status_controller.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method check_devel_package_status has a Cognitive Complexity of 19 (exceeds 8 allowed). Consider refactoring.
Wontfix

      def check_devel_package_status(currentpack, p)
        dp = p.develpack
        return unless dp

        dproject = dp.project
Severity: Minor
Found in src/api/app/controllers/webui/projects/status_controller.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method status_check_package has a Cognitive Complexity of 18 (exceeds 8 allowed). Consider refactoring.
Wontfix

      def status_check_package(package)
        currentpack = {}
        pname = package.name

        currentpack['requests_from'] = []
Severity: Minor
Found in src/api/app/controllers/webui/projects/status_controller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method status_check_package has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

      def status_check_package(package)
        currentpack = {}
        pname = package.name

        currentpack['requests_from'] = []
Severity: Minor
Found in src/api/app/controllers/webui/projects/status_controller.rb - About 1 hr to fix

    Method show has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Wontfix

          def show
            all_packages = 'All Packages'
            no_project = 'No Project'
            @no_project = '_none_'
            @all_projects = '_all_'
    Severity: Minor
    Found in src/api/app/controllers/webui/projects/status_controller.rb - About 1 hr to fix

      Method check_devel_package_status has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Wontfix

            def check_devel_package_status(currentpack, p)
              dp = p.develpack
              return unless dp
      
              dproject = dp.project
      Severity: Minor
      Found in src/api/app/controllers/webui/projects/status_controller.rb - About 1 hr to fix

        Consider simplifying this complex logical expression.
        Wontfix

                return unless currentpack['firstfail'] || currentpack['failedcomment'] || currentpack['upstream_version'] ||
                              !currentpack['problems'].empty? || !currentpack['requests_from'].empty? || !currentpack['requests_to'].empty?
        Severity: Major
        Found in src/api/app/controllers/webui/projects/status_controller.rb - About 40 mins to fix

          Method status_gather_requests has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring.
          Wontfix

                def status_gather_requests
                  # we do not filter requests for project because we need devel projects too later on and as long as the
                  # number of open requests is limited this is the easiest solution
                  raw_requests = BsRequest.order(:number).where(state: %i[new review declined]).joins(:bs_request_actions)
                                          .where(bs_request_actions: { type: %w[submit delete] }).pluck('bs_requests.number',
          Severity: Minor
          Found in src/api/app/controllers/webui/projects/status_controller.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status