openSUSE/open-build-service

View on GitHub
src/api/app/controllers/webui/search_controller.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method set_parameters has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

  def set_parameters
    @search_attrib_type_id = nil
    @search_attrib_type_id = params[:attrib_type_id] if params[:attrib_type_id].present?

    @search_issue = nil
Severity: Minor
Found in src/api/app/controllers/webui/search_controller.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method search has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

  def search
    # If there is nothing to search for, just return
    return unless params[:search_text]
    # If the search is too short, return too
    if (!@search_text || @search_text.length < 2) && !@search_attrib_type_id && !@search_issue
Severity: Minor
Found in src/api/app/controllers/webui/search_controller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method search has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def search
    # If there is nothing to search for, just return
    return unless params[:search_text]
    # If the search is too short, return too
    if (!@search_text || @search_text.length < 2) && !@search_attrib_type_id && !@search_issue
Severity: Minor
Found in src/api/app/controllers/webui/search_controller.rb - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

            return
    Severity: Major
    Found in src/api/app/controllers/webui/search_controller.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

            return
      Severity: Major
      Found in src/api/app/controllers/webui/search_controller.rb - About 30 mins to fix

        Method owner has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def owner
            # TODO: Remove if once migration of the view is finished
            switch_to_webui2 if Rails.env.development?
        
            Backend::Test.start if Rails.env.test?
        Severity: Minor
        Found in src/api/app/controllers/webui/search_controller.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status