openSUSE/open-build-service

View on GitHub
src/api/app/models/binary_release.rb

Summary

Maintainability
D
2 days
Test Coverage

Method update_binary_releases_via_json has a Cognitive Complexity of 55 (exceeds 5 allowed). Consider refactoring.
Open

  def self.update_binary_releases_via_json(repository, json, time = Time.now)
    oldlist = where(repository: repository, obsolete_time: nil, modify_time: nil)
    # we can not just remove it from relation, delete would affect the object.
    processed_item = {}

Severity: Minor
Found in src/api/app/models/binary_release.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method render_xml has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

  def render_xml
    builder = Nokogiri::XML::Builder.new
    builder.binary(render_attributes) do |binary|
      binary.operation(operation)

Severity: Minor
Found in src/api/app/models/binary_release.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update_binary_releases_via_json has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.update_binary_releases_via_json(repository, json, time = Time.now)
    oldlist = where(repository: repository, obsolete_time: nil, modify_time: nil)
    # we can not just remove it from relation, delete would affect the object.
    processed_item = {}

Severity: Major
Found in src/api/app/models/binary_release.rb - About 2 hrs to fix

    Method render_xml has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def render_xml
        builder = Nokogiri::XML::Builder.new
        builder.binary(render_attributes) do |binary|
          binary.operation(operation)
    
    
    Severity: Minor
    Found in src/api/app/models/binary_release.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status