src/api/app/models/binary_release.rb
Method update_binary_releases_via_json
has a Cognitive Complexity of 53 (exceeds 8 allowed). Consider refactoring. Open
Open
def self.update_binary_releases_via_json(repository, json, time = Time.now)
# building a hash to avoid single SQL select calls slowing us down too much
oldhash = {}
BinaryRelease.transaction do
where(repository: repository, obsolete_time: nil).each do |binary|
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method render_xml
has a Cognitive Complexity of 39 (exceeds 8 allowed). Consider refactoring. Open
Open
def render_xml
builder = Nokogiri::XML::Builder.new
builder.binary(render_attributes) do |binary|
binary.operation(operation)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method update_binary_releases_via_json
has 63 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
def self.update_binary_releases_via_json(repository, json, time = Time.now)
# building a hash to avoid single SQL select calls slowing us down too much
oldhash = {}
BinaryRelease.transaction do
where(repository: repository, obsolete_time: nil).each do |binary|
Method render_xml
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
def render_xml
builder = Nokogiri::XML::Builder.new
builder.binary(render_attributes) do |binary|
binary.operation(operation)