Showing 9 of 33 total issues
Function flattenNormalize
has a Cognitive Complexity of 39 (exceeds 20 allowed). Consider refactoring. Open
Open
func flattenNormalize(config *Config, flattened *map[string]interface{}) error {
// discover all controls
var allControls []string
// create the regex expressions we will use
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function flattenArray
has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring. Open
Open
func flattenArray(config *Config, value interface{}, key string, flattened *map[string]interface{}) (bool, error) {
// are we an array?
input, okArray := value.([]interface{})
if !okArray {
return false, nil
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function flattenNormalize
has 59 lines of code (exceeds 50 allowed). Consider refactoring. Open
Open
func flattenNormalize(config *Config, flattened *map[string]interface{}) error {
// discover all controls
var allControls []string
// create the regex expressions we will use
Function flattenArray
has 58 lines of code (exceeds 50 allowed). Consider refactoring. Open
Open
func flattenArray(config *Config, value interface{}, key string, flattened *map[string]interface{}) (bool, error) {
// are we an array?
input, okArray := value.([]interface{})
if !okArray {
return false, nil
Function flattenDriver
has 7 return statements (exceeds 4 allowed). Open
Open
func flattenDriver(config *Config, value interface{}, key string, flattened *map[string]interface{}) (bool, error) {
// account for unset value - just ignore (?)
if value == nil {
log.Printf("flatten: No value for %s\n", key)
return true, nil
Method vcsAndLocalFSGetter.GetLocalResources
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
func (g *vcsAndLocalFSGetter) GetLocalResources(source string, resources []string, destination string,
subfolder string, recursively bool, resourceType constants.ResourceType) error {
Method vcsAndLocalFSGetter.GetRemoteResources
has 6 return statements (exceeds 4 allowed). Open
Open
func (g *vcsAndLocalFSGetter) GetRemoteResources(destination string, subfolder string,
entries []common.RemoteSource) error {
// Create the temporary directory for where to clone all the remote resources.
tempResourcesDir, err := g.FSUtil.TempDir("", "opencontrol-resources")
if err != nil {
Method YAMLParser.Parse
has 5 return statements (exceeds 4 allowed). Open
Open
func (parser YAMLParser) Parse(data []byte) (common.OpenControl, error) {
if data == nil || len(data) == 0 {
return nil, common.ErrNoDataToParse
}
b := Base{}
Function exportJSON
has 5 return statements (exceeds 4 allowed). Open
Open
func exportJSON(config *Config, workspace common.Workspace, output *exportOutput, writer io.Writer) []error {
// result
var errors []error
// work vars