Sign upLogin

openmrs/openmrs-contrib-id

View on GitHub
Star

Showing 39 of 41 total issues

Function exports has 219 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports = module.exports = app => {


  app.get('/profile/email/verify/:id', (req, res, next) => {
    // check for valid email verification ID
Severity: Major
Found in app/routes/profile/email.js - About 1 day to fix

    Function exports has 191 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports = module.exports = app => {


  // get signup from /signup or from / and handle accordingly
  app.get(/^\/signup\/?$|^\/$/i, botproof.generators,
    Severity: Major
    Found in app/routes/signup/index.js - About 7 hrs to fix

      File ldap.js has 427 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      'use strict';
/**
 * The contents of this file are subject to the OpenMRS Public License
 * Version 1.1 (the "License"); you may not use this file except in
 * compliance with the License. You may obtain a copy of the License at
      Severity: Minor
      Found in app/ldap.js - About 6 hrs to fix

        Function exports has 147 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        exports = module.exports = app => {


  app.get('/reset', mid.forceLogout, (req, res, next) => {
    res.render('views/reset-public');
        Severity: Major
        Found in app/routes/reset-password/index.js - About 5 hrs to fix

          File user.js has 375 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          'use strict';
/**
 * This file defines the Schema of OpenMRS-ID
 */
          Severity: Minor
          Found in app/models/user.js - About 5 hrs to fix

            Function exports has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
            Open

            exports = module.exports = app => {


  app.get('/login', mid.forceLogout,
    (req, res, next) => {
            Severity: Minor
            Found in app/routes/auth/login.js - About 4 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function exports has 112 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            exports = module.exports = app => {


  app.get('/profile', mid.forceLogin,
    (req, res, next) => {
            Severity: Major
            Found in app/routes/profile/profile.js - About 4 hrs to fix

              Function exports has 103 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              exports = module.exports = app => {


  app.get('/login', mid.forceLogout,
    (req, res, next) => {
              Severity: Major
              Found in app/routes/auth/login.js - About 4 hrs to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                fs.readdirSync(__dirname).forEach(file => {
  const regex = /^(.*).js$/.exec(file);
  if (!regex[1]) {
    return;
  }
                Severity: Major
                Found in app/db-admin/models/index.js and 1 other location - About 3 hrs to fix
                app/models/index.js on lines 4..16

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 105.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                fs.readdirSync(__dirname).forEach(file => {
  const regex = /^(.*).js$/.exec(file);
  if (!regex[1]) {
    return;
  }
                Severity: Major
                Found in app/models/index.js and 1 other location - About 3 hrs to fix
                app/db-admin/models/index.js on lines 4..16

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 105.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function spamListLookup has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
                Open

                  spamListLookup: function spamListLookup(req, res, next) {
    const rev = reverseIp(req);
    const spams = signupConf.dnsSpamLists;

    // check the address with each list
                Severity: Minor
                Found in app/routes/signup/botproof.js - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function begin has 61 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                exports.begin = (settings, callback) => {
  // parse arguments
  const addr = settings.addr;
  const subject = settings.subject;
  const templatePath = settings.templatePath;
                Severity: Major
                Found in app/email-verification.js - About 2 hrs to fix

                  Function findAndSync has 58 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  const findAndSync = (filter, callback) => {

  const findMongo = cb => {
    User.findOne(filter, (err, user) => {
      if (err) {
                  Severity: Major
                  Found in app/models/user.js - About 2 hrs to fix

                    Function exports has 55 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    exports = module.exports = app => {


  // AJAX
  app.post('/password', mid.forceLogin,
                    Severity: Major
                    Found in app/routes/profile/password.js - About 2 hrs to fix

                      Function updateUser has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      exports.updateUser = (user, cb) => {
  // first check the validity
  checkAndConvert(user);
  const userDn = `${userAttr.rdn}=${user.username},${userAttr.baseDn}`;
                      Severity: Major
                      Found in app/ldap.js - About 2 hrs to fix

                        Function resetPassword has 49 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        exports.resetPassword = (username, newPass, cb) => {
  if (!userAttr.usernameRegex.test(username)) {
    return cb(new Error('Illegal username specified'));
  }
                        Severity: Minor
                        Found in app/ldap.js - About 1 hr to fix

                          Function exports has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                          Open

                          exports = module.exports = app => {


  app.get('/reset', mid.forceLogout, (req, res, next) => {
    res.render('views/reset-public');
                          Severity: Minor
                          Found in app/routes/reset-password/index.js - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  validate.perform(validators, (err, failures) => {
          if (err) {
            return callback(err);
          }
          if (_.isEmpty(failures)) {
                          Severity: Major
                          Found in app/routes/reset-password/index.js and 1 other location - About 1 hr to fix
                          app/routes/signup/index.js on lines 80..90

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 71.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  validate.perform(validators, (err, failures) => {
          if (err) {
            return callback(err);
          }
          if (_.isEmpty(failures)) {
                          Severity: Major
                          Found in app/routes/signup/index.js and 1 other location - About 1 hr to fix
                          app/routes/reset-password/index.js on lines 135..145

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 71.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Function spamListLookup has 42 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                            spamListLookup: function spamListLookup(req, res, next) {
    const rev = reverseIp(req);
    const spams = signupConf.dnsSpamLists;

    // check the address with each list
                          Severity: Minor
                          Found in app/routes/signup/botproof.js - About 1 hr to fix
                            Severity
                            Category
                            Status
                            Source
                            Language