Sign upLogin

opf/openproject

View on GitHub
Star
frontend/src/app/features/boards/board/board-list/board-list.component.ts

Summary

Maintainability
D
1 day
Test Coverage

File board-list.component.ts has 401 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import {
  ChangeDetectionStrategy,
  ChangeDetectorRef,
  Component,
  ElementRef,
Severity: Minor
Found in frontend/src/app/features/boards/board/board-list/board-list.component.ts - About 5 hrs to fix

    BoardListComponent has 29 functions (exceeds 20 allowed). Consider refactoring.
    Open

    @Component({
  selector: 'board-list',
  templateUrl: './board-list.component.html',
  styleUrls: ['./board-list.component.sass'],
  changeDetection: ChangeDetectionStrategy.OnPush,
    Severity: Minor
    Found in frontend/src/app/features/boards/board/board-list/board-list.component.ts - About 3 hrs to fix

      Function ngOnInit has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        ngOnInit():void {
    // Unset the isNew flag
    this.initiallyFocused = this.resource.isNewWidget;
    this.resource.isNewWidget = false;
      Severity: Minor
      Found in frontend/src/app/features/boards/board/board-list/board-list.component.ts - About 1 hr to fix

        Function loadActionAttribute has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          private async loadActionAttribute(query:QueryResource):Promise<void> {
    if (!this.board.isAction) {
      this.actionResource = undefined;
      this.headerComponent = undefined;
      this.canDragInto = !!query.updateOrderedWorkPackages;
        Severity: Minor
        Found in frontend/src/app/features/boards/board/board-list/board-list.component.ts - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            openStateLink(event:{ workPackageId:string; requestedState:string }) {
    const params = { workPackageId: event.workPackageId };

    if (event.requestedState === 'split') {
      this.keepTab.goCurrentDetailsState(params);
          Severity: Major
          Found in frontend/src/app/features/boards/board/board-list/board-list.component.ts and 1 other location - About 1 hr to fix
          frontend/src/app/features/team-planner/team-planner/planner/team-planner.component.ts on lines 824..832

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 70.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            openFullViewOnDoubleClick(event:{ workPackageId:string, double:boolean }) {
    if (event.double) {
      this.state.go(
        'work-packages.show',
        { workPackageId: event.workPackageId },
          Severity: Major
          Found in frontend/src/app/features/boards/board/board-list/board-list.component.ts and 1 other location - About 1 hr to fix
          frontend/src/app/features/work-packages/components/wp-table/embedded/wp-embedded-table.component.ts on lines 181..188

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 65.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status