opf/openproject

View on GitHub
frontend/src/app/features/team-planner/team-planner/planner/team-planner.component.ts

Summary

Maintainability
F
4 days
Test Coverage

File team-planner.component.ts has 758 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import {
  ChangeDetectionStrategy,
  Component,
  ElementRef,
  HostListener,

    TeamPlannerComponent has 47 functions (exceeds 20 allowed). Consider refactoring.
    Open

    @Component({
      selector: 'op-team-planner',
      templateUrl: './team-planner.component.html',
      styleUrls: ['./team-planner.component.sass'],
      changeDetection: ChangeDetectionStrategy.OnPush,

      Function initializeCalendar has 116 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        private initializeCalendar() {
          void this.configuration.initialized
            .then(() => {
              this.calendarOptions$.next(
                this.workPackagesCalendar.calendarOptions({

        Function ngOnInit has 61 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          ngOnInit():void {
            this.initializeCalendar();
            this.projectIdentifier = this.currentProject.identifier || undefined;
        
            this

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            isWpEndDateInCurrentView(workPackage:WorkPackageResource):boolean {
              const { dueDate } = workPackage;
          
              if (!dueDate) {
                return !!workPackage.date;
          frontend/src/app/features/team-planner/team-planner/planner/team-planner.component.ts on lines 635..646

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 118.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            isWpStartDateInCurrentView(workPackage:WorkPackageResource):boolean {
              const { startDate } = workPackage;
          
              if (!startDate) {
                return !!workPackage.date;
          frontend/src/app/features/team-planner/team-planner/planner/team-planner.component.ts on lines 622..633

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 118.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            openStateLink(event:{ workPackageId:string; requestedState:string }):void {
              const params = { workPackageId: event.workPackageId };
          
              if (event.requestedState === 'split') {
                this.keepTab.goCurrentDetailsState(params);
          frontend/src/app/features/boards/board/board-list/board-list.component.ts on lines 484..492

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 70.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              this.calendar.resize$
                .pipe(
                  this.untilDestroyed(),
                  debounceTime(50),
                )
          frontend/src/app/features/calendar/wp-calendar/wp-calendar.component.ts on lines 97..104

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 64.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            @ViewChild('ucCalendar', { read: ElementRef })
            set ucCalendarElement(v:ElementRef|undefined) {
              this.calendar.resizeObserver(v);
            }
          frontend/src/app/features/calendar/wp-calendar/wp-calendar.component.ts on lines 60..63

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status