Sign upLogin

opf/openproject

View on GitHub
Star
frontend/src/app/features/work-packages/components/wp-list/wp-list.service.ts

Summary

Maintainability
C
7 hrs
Test Coverage

File wp-list.service.ts has 309 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// -- copyright
// OpenProject is an open source project management software.
// Copyright (C) 2012-2024 the OpenProject GmbH
//
// This program is free software; you can redistribute it and/or
Severity: Minor
Found in frontend/src/app/features/work-packages/components/wp-list/wp-list.service.ts - About 3 hrs to fix

    WorkPackagesListService has 23 functions (exceeds 20 allowed). Consider refactoring.
    Open

    @Injectable()
export class WorkPackagesListService {
  // We remember the query requests coming in so we can ensure only the latest request is being tended to
  private queryRequests = input<QueryDefinition>();
    Severity: Minor
    Found in frontend/src/app/features/work-packages/components/wp-list/wp-list.service.ts - About 2 hrs to fix

      Function handleQueryLoadingError has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        private handleQueryLoadingError(
    error:ErrorResource,
    queryProps:{ [key:string]:unknown },
    queryId?:string|null,
    projectIdentifier?:string|null,
      Severity: Minor
      Found in frontend/src/app/features/work-packages/components/wp-list/wp-list.service.ts - About 1 hr to fix

        Function reloadSidemenu has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          private reloadSidemenu(selectedQueryId:string|null):void {
    const menuIdentifier:string|undefined = this.$state.current.data.sidemenuId;

    if (menuIdentifier) {
      const menu = (document.getElementById(menuIdentifier) as HTMLElement&TurboElement);
        Severity: Minor
        Found in frontend/src/app/features/work-packages/components/wp-list/wp-list.service.ts - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status