Sign upLogin

opf/openproject

View on GitHub
Star
frontend/src/app/features/work-packages/components/wp-query/url-params-helper.ts

Summary

Maintainability
D
1 day
Test Coverage

File url-params-helper.ts has 347 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// -- copyright
// OpenProject is an open source project management software.
// Copyright (C) 2012-2024 the OpenProject GmbH
//
// This program is free software; you can redistribute it and/or
Severity: Minor
Found in frontend/src/app/features/work-packages/components/wp-query/url-params-helper.ts - About 4 hrs to fix

    Function buildV3GetQueryFromJsonParams has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

      public buildV3GetQueryFromJsonParams(updateJson:string|null) {
    const queryData:Partial<QueryRequestParams> = {
      pageSize: this.paginationService.getPerPage(),
    };
    Severity: Minor
    Found in frontend/src/app/features/work-packages/components/wp-query/url-params-helper.ts - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function buildV3GetQueryFromJsonParams has 66 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      public buildV3GetQueryFromJsonParams(updateJson:string|null) {
    const queryData:Partial<QueryRequestParams> = {
      pageSize: this.paginationService.getPerPage(),
    };
    Severity: Major
    Found in frontend/src/app/features/work-packages/components/wp-query/url-params-helper.ts - About 2 hrs to fix

      UrlParamsHelperService has 21 functions (exceeds 20 allowed). Consider refactoring.
      Open

      @Injectable({ providedIn: 'root' })
export class UrlParamsHelperService {
  public constructor(public paginationService:PaginationService) {
  }
      Severity: Minor
      Found in frontend/src/app/features/work-packages/components/wp-query/url-params-helper.ts - About 2 hrs to fix

        Avoid too many return statements within this function.
        Open

            return value.toString();
        Severity: Major
        Found in frontend/src/app/features/work-packages/components/wp-query/url-params-helper.ts - About 30 mins to fix

          Function queryFilterValueToParam has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            public queryFilterValueToParam(value:HalResource|string|boolean):string {
    if (typeof (value) === 'boolean') {
      return value ? 't' : 'f';
    }
          Severity: Minor
          Found in frontend/src/app/features/work-packages/components/wp-query/url-params-helper.ts - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status