Sign upLogin

opf/openproject

View on GitHub
Star
frontend/src/app/features/work-packages/components/wp-table/timeline/container/wp-timeline-container.directive.ts

Summary

Maintainability
F
3 days
Test Coverage

File wp-timeline-container.directive.ts has 442 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// -- copyright
// OpenProject is an open source project management software.
// Copyright (C) 2012-2024 the OpenProject GmbH
//
// This program is free software; you can redistribute it and/or
Severity: Minor
Found in frontend/src/app/features/work-packages/components/wp-table/timeline/container/wp-timeline-container.directive.ts - About 6 hrs to fix

    WorkPackageTimelineTableController has 33 functions (exceeds 20 allowed). Consider refactoring.
    Open

    @Component({
  selector: 'wp-timeline-container',
  templateUrl: './wp-timeline-container.html',
})
export class WorkPackageTimelineTableController extends UntilDestroyedMixin implements AfterViewInit {
    Severity: Minor
    Found in frontend/src/app/features/work-packages/components/wp-table/timeline/container/wp-timeline-container.directive.ts - About 4 hrs to fix

      Function calculateViewParams has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        private calculateViewParams(currentParams:TimelineViewParameters):boolean {
    if (this.disableViewParamsCalculation) {
      return false;
    }
      Severity: Minor
      Found in frontend/src/app/features/work-packages/components/wp-table/timeline/container/wp-timeline-container.directive.ts - About 2 hrs to fix

        Function ngAfterViewInit has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          ngAfterViewInit() {
    this.$element = jQuery(this.elementRef.nativeElement);

    const scrollBar = document.querySelector('.work-packages-tabletimeline--timeline-side');
    if (scrollBar) {
        Severity: Minor
        Found in frontend/src/app/features/work-packages/components/wp-table/timeline/container/wp-timeline-container.directive.ts - About 1 hr to fix

          Function refreshView has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            refreshView() {
    if (!this.wpTableTimeline.isVisible) {
      debugLog('refreshView() requested, but TL is invisible.');
      return;
    }
          Severity: Minor
          Found in frontend/src/app/features/work-packages/components/wp-table/timeline/container/wp-timeline-container.directive.ts - About 1 hr to fix

            Function applyAutoZoomLevel has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

              private applyAutoZoomLevel() {
    if (this.workPackageIdOrder.length === 0) {
      return;
    }
            Severity: Minor
            Found in frontend/src/app/features/work-packages/components/wp-table/timeline/container/wp-timeline-container.directive.ts - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              startAddRelationPredecessor(start:WorkPackageResource) {
    this.activateSelectionMode(start.id!, (end) => {
      this.wpRelations
        .addCommonRelation(start.id!, 'follows', end.id!)
        .then(() => {
            Severity: Major
            Found in frontend/src/app/features/work-packages/components/wp-table/timeline/container/wp-timeline-container.directive.ts and 1 other location - About 5 hrs to fix
            frontend/src/app/features/work-packages/components/wp-table/timeline/container/wp-timeline-container.directive.ts on lines 306..319

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 148.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              startAddRelationFollower(start:WorkPackageResource) {
    this.activateSelectionMode(start.id!, (end) => {
      this.wpRelations
        .addCommonRelation(start.id!, 'precedes', end.id!)
        .then(() => {
            Severity: Major
            Found in frontend/src/app/features/work-packages/components/wp-table/timeline/container/wp-timeline-container.directive.ts and 1 other location - About 5 hrs to fix
            frontend/src/app/features/work-packages/components/wp-table/timeline/container/wp-timeline-container.directive.ts on lines 291..304

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 148.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

              isNonWorkingDay(date:Date|string):boolean {
    const formatted = moment(date).format('YYYY-MM-DD');
    return (this.nonWorkingDays.findIndex((el) => el.date === formatted) !== -1);
  }
            Severity: Major
            Found in frontend/src/app/features/work-packages/components/wp-table/timeline/container/wp-timeline-container.directive.ts and 2 other locations - About 1 hr to fix
            frontend/src/app/features/calendar/op-work-packages-calendar.service.ts on lines 154..157
            frontend/src/app/features/work-packages/routing/wp-view-base/view-services/wp-view-baseline.service.ts on lines 126..129

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 74.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status