opus-codium/riemann-bacula

View on GitHub
lib/riemann/tools/bacula.rb

Summary

Maintainability
A
3 hrs
Test Coverage
A
97%

Method enhance has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def enhance(data)
        # If the message on stdin was trucated, the last item might not make
        # sense.
        data.delete(data.keys.last) if data.keys.last != 'Termination'

Severity: Minor
Found in lib/riemann/tools/bacula.rb - About 1 hr to fix

    Method run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def run
            %i[job_name backup_level status].each do |name|
              raise("Parameter #{name} is required") unless opts[name]
            end
    
    
    Severity: Minor
    Found in lib/riemann/tools/bacula.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method parse has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def parse(text)
            data = {}
            line_continuation = nil
    
            text.each_line do |line|
    Severity: Minor
    Found in lib/riemann/tools/bacula.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status