ossert/ossert

View on GitHub

Showing 23 of 23 total issues

Class GitHub has 35 methods (exceeds 20 allowed). Consider refactoring.
Open

    class GitHub
      attr_reader :client, :project

      extend Forwardable
      def_delegators :project, :agility, :community, :meta
Severity: Minor
Found in lib/ossert/fetch/github.rb - About 4 hrs to fix

    File github.rb has 349 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'octokit'
    
    module Ossert
      module Fetch
        class GitHub
    Severity: Minor
    Found in lib/ossert/fetch/github.rb - About 4 hrs to fix

      Method process_issues has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
      Open

            def process_issues
              @issues_processed_in_days = []
      
              issues do |issue|
                next if issue.key? :pull_request
      Severity: Minor
      Found in lib/ossert/fetch/github.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method train_section_metrics_thresholds has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
      Open

            def self.train_section_metrics_thresholds(section_klass, period)
              raise ArgumentError unless PERIODS.include?(period)
      
              # TODO: move demodulize and whole logic to Utils somewhere
              section = section_klass.to_s.demodulize.underscore.split('_').first.to_sym
      Severity: Minor
      Found in lib/ossert/classifiers/cluster.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method process_pulls has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
      Open

            def process_pulls
              @pulls_processed_in_days = Set.new
      
              retry_call do
                pulls do |pull|
      Severity: Minor
      Found in lib/ossert/fetch/github.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Class Base has 21 methods (exceeds 20 allowed). Consider refactoring.
      Open

          class Base
            class << self
              attr_accessor :section, :section_type
      
              # @!attribute [rw] section
      Severity: Minor
      Found in lib/ossert/stats/base.rb - About 2 hrs to fix

        Method process_issues has 53 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def process_issues
                @issues_processed_in_days = []
        
                issues do |issue|
                  next if issue.key? :pull_request
        Severity: Major
        Found in lib/ossert/fetch/github.rb - About 2 hrs to fix

          Method process_pulls has 47 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                def process_pulls
                  @pulls_processed_in_days = Set.new
          
                  retry_call do
                    pulls do |pull|
          Severity: Minor
          Found in lib/ossert/fetch/github.rb - About 1 hr to fix

            Method train_section_metrics_thresholds has 46 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  def self.train_section_metrics_thresholds(section_klass, period)
                    raise ArgumentError unless PERIODS.include?(period)
            
                    # TODO: move demodulize and whole logic to Utils somewhere
                    section = section_klass.to_s.demodulize.underscore.split('_').first.to_sym
            Severity: Minor
            Found in lib/ossert/classifiers/cluster.rb - About 1 hr to fix

              Method process has 44 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                    def process
                      contributors do |c|
                        login = c.try(:[], :login).presence || generate_anonymous
                        community.total.contributors << login
                      end
              Severity: Minor
              Found in lib/ossert/fetch/github.rb - About 1 hr to fix

                Method with_reference has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                        def with_reference(text, value, metric, type)
                          return (text.to_i.positive? ? "+#{text}" : text).to_s if type == :delta
                
                          metric_by_ref = @reference[type][metric.to_s]
                          reference = Project::CLASSES.inject('NaN') do |acc, ref|
                Severity: Minor
                Found in lib/ossert/presenters/project.rb - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      def process_users_from_pull(pull)
                        community.total.users_creating_pr << pull[:user][:login]
                        community.quarters[pull[:created_at]].users_creating_pr << pull[:user][:login]
                        community.total.users_involved << pull[:user][:login]
                        community.quarters[pull[:created_at]].users_involved << pull[:user][:login]
                Severity: Minor
                Found in lib/ossert/fetch/github.rb and 1 other location - About 55 mins to fix
                lib/ossert/fetch/github.rb on lines 290..294

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 46.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      def process_users_from_issue(issue)
                        community.total.users_creating_issues << issue[:user][:login]
                        community.quarters[issue[:created_at]].users_creating_issues << issue[:user][:login]
                        community.total.users_involved << issue[:user][:login]
                        community.quarters[issue[:created_at]].users_involved << issue[:user][:login]
                Severity: Minor
                Found in lib/ossert/fetch/github.rb and 1 other location - About 55 mins to fix
                lib/ossert/fetch/github.rb on lines 207..211

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 46.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Method all has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    def all(project)
                      all_fetchers.each do |fetcher|
                        puts "======> with #{fetcher}..."
                        retry_count = 3
                        begin
                Severity: Minor
                Found in lib/ossert/fetch.rb - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method << has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                      def <<(other_stats)
                        self.class.attributes_names.each do |attr|
                          next unless (other_value = other_stats.instance_variable_get("@#{attr}"))
                          new_value = other_value
                          new_value += instance_variable_get("@#{attr}") unless self.class.absolute_attributes.include?(attr)
                Severity: Minor
                Found in lib/ossert/stats/base.rb - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method run_aggregation has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                        def run_aggregation
                          GRADES.each_with_index do |grade, idx|
                            classifier[grade].each_pair do |metric, values|
                              all_values = values
                              all_values += classifier[GRADES[idx + 1]][metric] if (idx + 1) < GRADES.count
                Severity: Minor
                Found in lib/ossert/classifiers/growing/classifier.rb - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method process_using has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        def process_using(action, config, project, classifiers, last_year_offset = 1)
                Severity: Minor
                Found in lib/ossert/classifiers/check.rb - About 35 mins to fix

                  Method sum_up_checks has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                        def sum_up_checks(graph_data, check, results, index, offset)
                  Severity: Minor
                  Found in lib/ossert/presenters/project_v2.rb - About 35 mins to fix

                    Method load has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def self.load(*configs)
                          config_data = configs.each_with_object({}) do |config, result|
                            if (path = File.join(CONFIG_ROOT, "#{config}.yml")) && File.exist?(path.to_s)
                              result.merge! YAML.safe_load(IO.read(path.to_s))
                            end
                    Severity: Minor
                    Found in lib/ossert/config.rb - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method run_reverse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                          def run_reverse
                            CLASSIFIERS.each do |classifier_name|
                              classifier = @classifiers[classifier_name]
                              reversed_metrics.each do |reversed_metric|
                                GRADES.first(GRADES.count / 2).each do |grade|
                    Severity: Minor
                    Found in lib/ossert/classifiers/cluster.rb - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language