Sign upLogin

ota42y/openapi_parser

View on GitHub
Star

Showing 28 of 28 total issues

Method coerce_and_validate has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    def coerce_and_validate(value, schema, parent_all_of: false, parent_discriminator_schemas: [], discriminator_property_name: nil)
      return OpenAPIParser::ValidateError.build_error_result(value, schema) unless value.kind_of?(Hash)

      properties = schema.properties || {}
Severity: Minor
Found in lib/openapi_parser/schema_validator/object_validator.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method coerce_and_validate has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    def coerce_and_validate(value, schema, **keyword_args)
      if value.nil? && schema.nullable
        return [value, nil]
      end
Severity: Minor
Found in lib/openapi_parser/schema_validator/all_of_validator.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method coerce_and_validate has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def coerce_and_validate(value, schema, parent_all_of: false, parent_discriminator_schemas: [], discriminator_property_name: nil)
      return OpenAPIParser::ValidateError.build_error_result(value, schema) unless value.kind_of?(Hash)

      properties = schema.properties || {}
Severity: Minor
Found in lib/openapi_parser/schema_validator/object_validator.rb - About 1 hr to fix

    Method find_object has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      def find_object(reference)
    return self if object_reference == reference
    remote_reference = !reference.start_with?('#')
    return find_remote_object(reference) if remote_reference
    return nil unless reference.start_with?(object_reference)
    Severity: Minor
    Found in lib/openapi_parser/concerns/findable.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method coerce_and_validate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def coerce_and_validate(value, schema, **_keyword_args)
      return OpenAPIParser::ValidateError.build_error_result(value, schema) unless value.kind_of?(String)

      value, err = check_enum_include(value, schema)
      return [nil, err] if err
    Severity: Minor
    Found in lib/openapi_parser/schema_validator/string_validator.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method validate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

          def validate(value, schema)
        reference = schema.object_reference

        if schema.minimum
          if schema.exclusiveMinimum && value <= schema.minimum
    Severity: Minor
    Found in lib/openapi_parser/schema_validator/minimum_maximum.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method expand_list_objects has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def expand_list_objects(root, attribute_names, validate_references)
      return unless attribute_names

      attribute_names.each do |name|
        l = send(name)
    Severity: Minor
    Found in lib/openapi_parser/concerns/expandable.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def validate_max_min_items(value, schema)
      return [nil, OpenAPIParser::MoreThanMaxItems.new(value, schema.object_reference)] if schema.maxItems && value.length > schema.maxItems
      return [nil, OpenAPIParser::LessThanMinItems.new(value, schema.object_reference)] if schema.minItems && value.length < schema.minItems

      [value, nil]
    Severity: Minor
    Found in lib/openapi_parser/schema_validator/array_validator.rb and 1 other location - About 45 mins to fix
    lib/openapi_parser/schema_validator/string_validator.rb on lines 48..52

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 41.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          def validate_max_min_length(value, schema)
        return [nil, OpenAPIParser::MoreThanMaxLength.new(value, schema.object_reference)] if schema.maxLength && value.size > schema.maxLength
        return [nil, OpenAPIParser::LessThanMinLength.new(value, schema.object_reference)] if schema.minLength && value.size < schema.minLength

        [value, nil]
    Severity: Minor
    Found in lib/openapi_parser/schema_validator/string_validator.rb and 1 other location - About 45 mins to fix
    lib/openapi_parser/schema_validator/array_validator.rb on lines 28..32

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 41.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method parse_path_parameters has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def parse_path_parameters(schema_path, request_path)
    parameters = path_parameters(schema_path)
    return nil if parameters.empty?

    # If there are regex special characters in the path, the regex will
    Severity: Minor
    Found in lib/openapi_parser/path_item_finder.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method validate_parameter has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def validate_parameter(parameters_hash, params, object_reference, options, is_header = false)
      no_exist_required_key = []

      params_key_converted = params.keys.map { |k| [convert_key(k, is_header), k] }.to_h
      parameters_hash.each do |k, v|
    Severity: Minor
    Found in lib/openapi_parser/parameter_validator.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method expand_objects has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def expand_objects(root, attribute_names, validate_references)
      return unless attribute_names

      attribute_names.each do |name|
        v = send(name)
    Severity: Minor
    Found in lib/openapi_parser/concerns/expandable.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method validate_parameter has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def validate_parameter(parameters_hash, params, object_reference, options, is_header = false)
    Severity: Minor
    Found in lib/openapi_parser/parameter_validator.rb - About 35 mins to fix

      Method select_media_type_from_content has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def select_media_type_from_content(content_type, content)
      return nil unless content_type
      return nil unless content

      if (media_type = content[content_type])
      Severity: Minor
      Found in lib/openapi_parser/concerns/media_type_selectable.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method coerce_and_validate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def coerce_and_validate(value, schema, **_keyword_args)
      return OpenAPIParser::ValidateError.build_error_result(value, schema) unless value.kind_of?(Array)

      value, err = validate_max_min_items(value, schema)
      return [nil, err] if err
      Severity: Minor
      Found in lib/openapi_parser/schema_validator/array_validator.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

            return [nil, err] if err
      Severity: Major
      Found in lib/openapi_parser/schema_validator/string_validator.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

              return [nil, err] if err
        Severity: Major
        Found in lib/openapi_parser/schema_validator/string_validator.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                return child
          Severity: Major
          Found in lib/openapi_parser/concerns/findable.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                  return [nil, OpenAPIParser::NotExistRequiredKey.new(required_set.to_a, schema.object_reference)] unless required_set.empty?
            Severity: Major
            Found in lib/openapi_parser/schema_validator/object_validator.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return media_type
              Severity: Major
              Found in lib/openapi_parser/concerns/media_type_selectable.rb - About 30 mins to fix
                Severity
                Category
                Status
                Source
                Language