Sign upLogin

owncloud/core

View on GitHub
Star
lib/private/App/CodeChecker/NodeVisitor.php

Summary

Maintainability
D
2 days
Test Coverage

Function enterNode has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
Open

    public function enterNode(Node $node) {
        if ($this->checkEqualOperatorUsage && $node instanceof Node\Expr\BinaryOp\Equal) {
            $this->errors[]= [
                'disallowedToken' => '==',
                'errorCode' => CodeChecker::OP_OPERATOR_USAGE_DISCOURAGED,
Severity: Minor
Found in lib/private/App/CodeChecker/NodeVisitor.php - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method enterNode has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function enterNode(Node $node) {
        if ($this->checkEqualOperatorUsage && $node instanceof Node\Expr\BinaryOp\Equal) {
            $this->errors[]= [
                'disallowedToken' => '==',
                'errorCode' => CodeChecker::OP_OPERATOR_USAGE_DISCOURAGED,
Severity: Major
Found in lib/private/App/CodeChecker/NodeVisitor.php - About 2 hrs to fix

    Function addUseNameToBlackList has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        private function addUseNameToBlackList($name, $alias) {
        $name = \strtolower($name);
        $alias = \strtolower($alias);

        foreach ($this->blackListedClassNames as $blackListedAlias => $blackListedClassName) {
    Severity: Minor
    Found in lib/private/App/CodeChecker/NodeVisitor.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method __construct has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function __construct(ICheck $list) {
        $this->list = $list;

        $this->blackListedClassNames = [];
        foreach ($list->getClasses() as $class => $blackListInfo) {
    Severity: Minor
    Found in lib/private/App/CodeChecker/NodeVisitor.php - About 1 hr to fix

      Method addUseNameToBlackList has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function addUseNameToBlackList($name, $alias) {
        $name = \strtolower($name);
        $alias = \strtolower($alias);

        foreach ($this->blackListedClassNames as $blackListedAlias => $blackListedClassName) {
      Severity: Minor
      Found in lib/private/App/CodeChecker/NodeVisitor.php - About 1 hr to fix

        Function __construct has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function __construct(ICheck $list) {
        $this->list = $list;

        $this->blackListedClassNames = [];
        foreach ($list->getClasses() as $class => $blackListInfo) {
        Severity: Minor
        Found in lib/private/App/CodeChecker/NodeVisitor.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            private function checkBlackListConstant($class, $constantName, Node $node) {
        $name = $class . '::' . $constantName;
        $lowerName = \strtolower($name);

        if (isset($this->blackListedConstants[$lowerName])) {
        Severity: Major
        Found in lib/private/App/CodeChecker/NodeVisitor.php and 2 other locations - About 1 hr to fix
        lib/private/App/CodeChecker/NodeVisitor.php on lines 271..283
        lib/private/App/CodeChecker/NodeVisitor.php on lines 285..297

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 117.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            private function checkBlackListFunction($class, $functionName, Node $node) {
        $name = $class . '::' . $functionName;
        $lowerName = \strtolower($name);

        if (isset($this->blackListedFunctions[$lowerName])) {
        Severity: Major
        Found in lib/private/App/CodeChecker/NodeVisitor.php and 2 other locations - About 1 hr to fix
        lib/private/App/CodeChecker/NodeVisitor.php on lines 257..269
        lib/private/App/CodeChecker/NodeVisitor.php on lines 285..297

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 117.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            private function checkBlackListMethod($class, $functionName, Node $node) {
        $name = $class . '::' . $functionName;
        $lowerName = \strtolower($name);

        if (isset($this->blackListedMethods[$lowerName])) {
        Severity: Major
        Found in lib/private/App/CodeChecker/NodeVisitor.php and 2 other locations - About 1 hr to fix
        lib/private/App/CodeChecker/NodeVisitor.php on lines 257..269
        lib/private/App/CodeChecker/NodeVisitor.php on lines 271..283

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 117.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status