owncloud/core

View on GitHub
lib/private/App/DependencyAnalyzer.php

Summary

Maintainability
C
1 day
Test Coverage

Function analyzeLibraries has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    private function analyzeLibraries(array $dependencies) {
        $missing = [];
        if (!isset($dependencies['lib'])) {
            return $missing;
        }
Severity: Minor
Found in lib/private/App/DependencyAnalyzer.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method analyzeLibraries has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function analyzeLibraries(array $dependencies) {
        $missing = [];
        if (!isset($dependencies['lib'])) {
            return $missing;
        }
Severity: Minor
Found in lib/private/App/DependencyAnalyzer.php - About 1 hr to fix

    Function analyzeOC has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        private function analyzeOC(array $dependencies, array $appInfo) {
            $missing = [];
            $minVersion = null;
            if (isset($dependencies['owncloud']['@attributes']['min-version'])) {
                $minVersion = $dependencies['owncloud']['@attributes']['min-version'];
    Severity: Minor
    Found in lib/private/App/DependencyAnalyzer.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function analyzeCommands has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        private function analyzeCommands(array $dependencies) {
            $missing = [];
            if (!isset($dependencies['command'])) {
                return $missing;
            }
    Severity: Minor
    Found in lib/private/App/DependencyAnalyzer.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method analyzeOC has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function analyzeOC(array $dependencies, array $appInfo) {
            $missing = [];
            $minVersion = null;
            if (isset($dependencies['owncloud']['@attributes']['min-version'])) {
                $minVersion = $dependencies['owncloud']['@attributes']['min-version'];
    Severity: Minor
    Found in lib/private/App/DependencyAnalyzer.php - About 1 hr to fix

      Function analyzePhpVersion has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          private function analyzePhpVersion(array $dependencies) {
              $missing = [];
              if (isset($dependencies['php']['@attributes']['min-version'])) {
                  $minVersion = $dependencies['php']['@attributes']['min-version'];
                  if ($this->compareSmaller($this->platform->getPhpVersion(), $minVersion)) {
      Severity: Minor
      Found in lib/private/App/DependencyAnalyzer.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status