Sign upLogin

owncloud/core

View on GitHub
Star
lib/private/App/InfoParser.php

Summary

Maintainability
D
1 day
Test Coverage

Function parse has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
Open

    public function parse($file) {
        if (!\is_file($file)) {
            throw new AppNotFoundException(
                \sprintf('%s does not exist', $file)
            );
Severity: Minor
Found in lib/private/App/InfoParser.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function xmlToArray has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    protected function xmlToArray($xml) {
        if (!$xml->children()) {
            return (string)$xml;
        }
Severity: Minor
Found in lib/private/App/InfoParser.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse has 90 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function parse($file) {
        if (!\is_file($file)) {
            throw new AppNotFoundException(
                \sprintf('%s does not exist', $file)
            );
Severity: Major
Found in lib/private/App/InfoParser.php - About 3 hrs to fix

    Method xmlToArray has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function xmlToArray($xml) {
        if (!$xml->children()) {
            return (string)$xml;
        }
    Severity: Minor
    Found in lib/private/App/InfoParser.php - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status