Sign upLogin

owncloud/core

View on GitHub
Star
lib/private/App/PlatformRepository.php

Summary

Maintainability
C
1 day
Test Coverage

Function initialize has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    protected function initialize() {
        $loadedExtensions = \get_loaded_extensions();
        $packages = [];

        // Extensions scanning
Severity: Minor
Found in lib/private/App/PlatformRepository.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function initialize() {
        $loadedExtensions = \get_loaded_extensions();
        $packages = [];

        // Extensions scanning
Severity: Major
Found in lib/private/App/PlatformRepository.php - About 2 hrs to fix

    Function normalizeVersion has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        public function normalizeVersion($version, $fullVersion = null) {
        $version = \trim($version);
        if ($fullVersion === null) {
            $fullVersion = $version;
        }
    Severity: Minor
    Found in lib/private/App/PlatformRepository.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method normalizeVersion has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function normalizeVersion($version, $fullVersion = null) {
        $version = \trim($version);
        if ($fullVersion === null) {
            $fullVersion = $version;
        }
    Severity: Minor
    Found in lib/private/App/PlatformRepository.php - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

                      return $stability;
      Severity: Major
      Found in lib/private/App/PlatformRepository.php - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status