Sign upLogin

owncloud/core

View on GitHub
Star
lib/private/AppFramework/Http/Dispatcher.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method dispatch has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function dispatch(Controller $controller, $methodName) {
        $out = [null, [], null];

        try {
            // prefill reflector with everything thats needed for the
Severity: Minor
Found in lib/private/AppFramework/Http/Dispatcher.php - About 1 hr to fix

    Function executeController has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        private function executeController($controller, $methodName) {
        $arguments = [];

        // valid types that will be casted
        $types = ['int', 'integer', 'bool', 'boolean', 'float'];
    Severity: Minor
    Found in lib/private/AppFramework/Http/Dispatcher.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method executeController has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function executeController($controller, $methodName) {
        $arguments = [];

        // valid types that will be casted
        $types = ['int', 'integer', 'bool', 'boolean', 'float'];
    Severity: Minor
    Found in lib/private/AppFramework/Http/Dispatcher.php - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

                  if (($type === 'bool' || $type === 'boolean') &&
                $value === 'false' &&
                (
                    $this->request->method === 'GET' ||
                    \strpos(
      Severity: Major
      Found in lib/private/AppFramework/Http/Dispatcher.php - About 40 mins to fix

        There are no issues that match your filters.

        Category
        Status