owncloud/core

View on GitHub
lib/private/AppFramework/Routing/RouteConfig.php

Summary

Maintainability
B
6 hrs
Test Coverage

Method processOCS has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function processOCS(array $routes) {
        $ocsRoutes = isset($routes['ocs']) ? $routes['ocs'] : [];
        foreach ($ocsRoutes as $ocsRoute) {
            $name = $ocsRoute['name'];
            $postFix = '';
Severity: Minor
Found in lib/private/AppFramework/Routing/RouteConfig.php - About 1 hr to fix

    Method processResources has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function processResources($routes) {
            // declaration of all restful actions
            $actions = [
                ['name' => 'index', 'verb' => 'GET', 'on-collection' => true],
                ['name' => 'show', 'verb' => 'GET'],
    Severity: Minor
    Found in lib/private/AppFramework/Routing/RouteConfig.php - About 1 hr to fix

      Method processSimpleRoutes has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function processSimpleRoutes($routes) {
              $simpleRoutes = isset($routes['routes']) ? $routes['routes'] : [];
              foreach ($simpleRoutes as $simpleRoute) {
                  $name = $simpleRoute['name'];
                  $postfix = '';
      Severity: Minor
      Found in lib/private/AppFramework/Routing/RouteConfig.php - About 1 hr to fix

        Function processOCS has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            private function processOCS(array $routes) {
                $ocsRoutes = isset($routes['ocs']) ? $routes['ocs'] : [];
                foreach ($ocsRoutes as $ocsRoute) {
                    $name = $ocsRoute['name'];
                    $postFix = '';
        Severity: Minor
        Found in lib/private/AppFramework/Routing/RouteConfig.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function processResources has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            private function processResources($routes) {
                // declaration of all restful actions
                $actions = [
                    ['name' => 'index', 'verb' => 'GET', 'on-collection' => true],
                    ['name' => 'show', 'verb' => 'GET'],
        Severity: Minor
        Found in lib/private/AppFramework/Routing/RouteConfig.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function processSimpleRoutes has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            private function processSimpleRoutes($routes) {
                $simpleRoutes = isset($routes['routes']) ? $routes['routes'] : [];
                foreach ($simpleRoutes as $simpleRoute) {
                    $name = $simpleRoute['name'];
                    $postfix = '';
        Severity: Minor
        Found in lib/private/AppFramework/Routing/RouteConfig.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status