Sign upLogin

owncloud/core

View on GitHub
Star
lib/private/Avatar.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function getFile has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public function getFile($size) {
        $ext = $this->getExtension();

        $basePath = "{$this->path}/avatar.$ext";
Severity: Minor
Found in lib/private/Avatar.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method set has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function set($data) {
        if ($data instanceof IImage) {
            $img = $data;
            $data = $img->data();
        } else {
Severity: Minor
Found in lib/private/Avatar.php - About 1 hr to fix

    Method getFile has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getFile($size) {
        $ext = $this->getExtension();

        $basePath = "{$this->path}/avatar.$ext";
    Severity: Minor
    Found in lib/private/Avatar.php - About 1 hr to fix

      Function set has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public function set($data) {
        if ($data instanceof IImage) {
            $img = $data;
            $data = $img->data();
        } else {
      Severity: Minor
      Found in lib/private/Avatar.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status