Sign upLogin

owncloud/core

View on GitHub
Star
lib/private/Console/Application.php

Summary

Maintainability
C
1 day
Test Coverage

Function loadCommands has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    public function loadCommands(InputInterface $input, OutputInterface $output) {
        // $application is required to be defined in the register_command scripts
        $application = $this->application;
        $inputDefinition = $application->getDefinition();
        $inputDefinition->addOption(
Severity: Minor
Found in lib/private/Console/Application.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method loadCommands has 66 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function loadCommands(InputInterface $input, OutputInterface $output) {
        // $application is required to be defined in the register_command scripts
        $application = $this->application;
        $inputDefinition = $application->getDefinition();
        $inputDefinition->addOption(
Severity: Major
Found in lib/private/Console/Application.php - About 2 hrs to fix

    Function loadCommandsFromInfoXml has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        private function loadCommandsFromInfoXml($commands) {
        foreach ($commands as $command) {
            try {
                $c = \OC::$server->query($command);
            } catch (QueryException $e) {
    Severity: Minor
    Found in lib/private/Console/Application.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status