Sign upLogin

owncloud/core

View on GitHub
Star
lib/private/DB/Connection.php

Summary

Maintainability
B
5 hrs
Test Coverage

Connection has 29 functions (exceeds 20 allowed). Consider refactoring.
Open

class Connection extends \Doctrine\DBAL\Connection implements IDBConnection {
    /**
     * @var string $tablePrefix
     */
    protected $tablePrefix;
Severity: Minor
Found in lib/private/DB/Connection.php - About 3 hrs to fix

    Method setValues has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function setValues($table, array $keys, array $values, array $updatePreconditionValues = []) {
        // Try to insert whole record into the table ($toInsert) if predicate NOT EXISTS ($compare) is satisfied
        $toInsert = \array_merge($keys, $values);
        $compare = \array_keys($keys);
        $tableName = $this->tablePrefix . $table;
    Severity: Minor
    Found in lib/private/DB/Connection.php - About 1 hr to fix

      Function setValues has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public function setValues($table, array $keys, array $values, array $updatePreconditionValues = []) {
        // Try to insert whole record into the table ($toInsert) if predicate NOT EXISTS ($compare) is satisfied
        $toInsert = \array_merge($keys, $values);
        $compare = \array_keys($keys);
        $tableName = $this->tablePrefix . $table;
      Severity: Minor
      Found in lib/private/DB/Connection.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status