Sign upLogin

owncloud/core

View on GitHub
Star
lib/private/DB/MigrationService.php

Summary

Maintainability
C
1 day
Test Coverage

MigrationService has 22 functions (exceeds 20 allowed). Consider refactoring.
Open

class MigrationService {
    /** @var boolean */
    private $migrationTableCreated;
    /** @var array */
    private $migrations;
Severity: Minor
Found in lib/private/DB/MigrationService.php - About 2 hrs to fix

    File MigrationService.php has 255 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * @author Thomas Müller <thomas.mueller@tmit.eu>
 * @author Vincent Petry <pvince81@owncloud.com>
 *
    Severity: Minor
    Found in lib/private/DB/MigrationService.php - About 2 hrs to fix

      Method __construct has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function __construct(
        $appName,
        IDBConnection $connection,
        IOutput $output = null,
        AppLocator $appLocator = null,
      Severity: Minor
      Found in lib/private/DB/MigrationService.php - About 1 hr to fix

        Method findMigrations has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function findMigrations() {
        $directory = \realpath($this->migrationsPath);
        $iterator = new \RegexIterator(
            new \RecursiveIteratorIterator(
                new \RecursiveDirectoryIterator($directory, \FilesystemIterator::SKIP_DOTS),
        Severity: Minor
        Found in lib/private/DB/MigrationService.php - About 1 hr to fix

          Function __construct has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public function __construct(
        $appName,
        IDBConnection $connection,
        IOutput $output = null,
        AppLocator $appLocator = null,
          Severity: Minor
          Found in lib/private/DB/MigrationService.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function executeStep has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public function executeStep($version) {
        $this->logger->debug("Migrations: starting $version from app {$this->appName}", ['app' => 'core']);
        $instance = $this->createInstance($version);
        if ($instance instanceof ISimpleMigration) {
            $instance->run($this->output);
          Severity: Minor
          Found in lib/private/DB/MigrationService.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  $appName,
        IDBConnection $connection,
        IOutput $output = null,
        AppLocator $appLocator = null,
        ILogger $logger = null
          Severity: Minor
          Found in lib/private/DB/MigrationService.php - About 35 mins to fix

            Function getMigrationsToExecute has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                private function getMigrationsToExecute($to) {
        $knownMigrations = $this->getMigratedVersions();
        $availableMigrations = $this->getAvailableVersions();

        $toBeExecuted = [];
            Severity: Minor
            Found in lib/private/DB/MigrationService.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                    return '0';
            Severity: Major
            Found in lib/private/DB/MigrationService.php - About 30 mins to fix

              There are no issues that match your filters.

              Category
              Status