Sign upLogin

owncloud/core

View on GitHub
Star
lib/private/Files/External/LegacyUtil.php

Summary

Maintainability
C
7 hrs
Test Coverage

Function getBackendStatus has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public static function getBackendStatus($class, $options, $isPersonal, $testOnly = true) {
        if (self::$skipTest) {
            return StorageNotAvailableException::STATUS_SUCCESS;
        }
        $user = \OC::$server->getUserSession()->getUser();
Severity: Minor
Found in lib/private/Files/External/LegacyUtil.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getBackendStatus has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function getBackendStatus($class, $options, $isPersonal, $testOnly = true) {
        if (self::$skipTest) {
            return StorageNotAvailableException::STATUS_SUCCESS;
        }
        $user = \OC::$server->getUserSession()->getUser();
Severity: Minor
Found in lib/private/Files/External/LegacyUtil.php - About 1 hr to fix

    Method getAbsoluteMountPoints has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function getAbsoluteMountPoints($uid) {
        $mountPoints = [];

        $userGlobalStoragesService = \OC::$server->getUserGlobalStoragesService();
        '@phan-var \OC\Files\External\Service\UserGlobalStoragesService $userGlobalStoragesService';
    Severity: Minor
    Found in lib/private/Files/External/LegacyUtil.php - About 1 hr to fix

      Function setUserVars has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function setUserVars($user, $input) {
        if (\is_array($input)) {
            foreach ($input as $key => $value) {
                if (\is_string($value)) {
                    $input[$key] = \str_replace('$user', $user, $value);
      Severity: Minor
      Found in lib/private/Files/External/LegacyUtil.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getAbsoluteMountPoints has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function getAbsoluteMountPoints($uid) {
        $mountPoints = [];

        $userGlobalStoragesService = \OC::$server->getUserGlobalStoragesService();
        '@phan-var \OC\Files\External\Service\UserGlobalStoragesService $userGlobalStoragesService';
      Severity: Minor
      Found in lib/private/Files/External/LegacyUtil.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public static function setUserVars($user, $input) {
        if (\is_array($input)) {
            foreach ($input as $key => $value) {
                if (\is_string($value)) {
                    $input[$key] = \str_replace('$user', $user, $value);
      Severity: Major
      Found in lib/private/Files/External/LegacyUtil.php and 1 other location - About 1 hr to fix
      lib/private/Files/External/ConfigAdapter.php on lines 193..206

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 106.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              foreach ($userGlobalStoragesService->getStorages() as $storage) {
            /** @var IStorageConfig $storage */
            $mountPoint = '/'.$uid.'/files'.$storage->getMountPoint();
            $mountEntry = self::prepareMountPointEntry($storage, false);
            foreach ($mountEntry['options'] as &$option) {
      Severity: Minor
      Found in lib/private/Files/External/LegacyUtil.php and 1 other location - About 35 mins to fix
      lib/private/Files/External/LegacyUtil.php on lines 75..82

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 92.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              foreach ($userStoragesService->getStorages() as $storage) {
            $mountPoint = '/'.$uid.'/files'.$storage->getMountPoint();
            $mountEntry = self::prepareMountPointEntry($storage, true);
            foreach ($mountEntry['options'] as &$option) {
                $option = self::setUserVars($user->getUserName(), $option);
      Severity: Minor
      Found in lib/private/Files/External/LegacyUtil.php and 1 other location - About 35 mins to fix
      lib/private/Files/External/LegacyUtil.php on lines 65..73

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 92.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status