Sign upLogin

owncloud/core

View on GitHub
Star
lib/private/Files/External/Service/LegacyStoragesService.php

Summary

Maintainability
C
1 day
Test Coverage

Function getAllStorages has a Cognitive Complexity of 48 (exceeds 5 allowed). Consider refactoring.
Open

    public function getAllStorages() {
        $mountPoints = $this->readLegacyConfig();
        /**
         * Here is the how the horribly messy mount point array looks like
         * from the mount.json file:
Severity: Minor
Found in lib/private/Files/External/Service/LegacyStoragesService.php - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getAllStorages has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getAllStorages() {
        $mountPoints = $this->readLegacyConfig();
        /**
         * Here is the how the horribly messy mount point array looks like
         * from the mount.json file:
Severity: Major
Found in lib/private/Files/External/Service/LegacyStoragesService.php - About 2 hrs to fix

    Method populateStorageConfigWithLegacyOptions has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function populateStorageConfigWithLegacyOptions(
        &$storageConfig,
        $mountType,
        $applicable,
        $storageOptions
    Severity: Minor
    Found in lib/private/Files/External/Service/LegacyStoragesService.php - About 1 hr to fix

      Function populateStorageConfigWithLegacyOptions has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function populateStorageConfigWithLegacyOptions(
        &$storageConfig,
        $mountType,
        $applicable,
        $storageOptions
      Severity: Minor
      Found in lib/private/Files/External/Service/LegacyStoragesService.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status