owncloud/core

View on GitHub
lib/private/Files/External/Service/UserStoragesService.php

Summary

Maintainability
A
3 hrs
Test Coverage

Function deleteAllMountsForUser has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public function deleteAllMountsForUser(IUser $user) {
        $getUserMounts = $this->userMountCache->getMountsForUser($user);
        $allMounts = $this->dbConfig->getAllMounts();
        $result = false;
        if (\count($getUserMounts) > 0) {
Severity: Minor
Found in lib/private/Files/External/Service/UserStoragesService.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        IStoragesBackendService $backendService,
        DBConfigService $dbConfig,
        IUserSession $userSession,
        IUserMountCache $userMountCache,
        ICrypto $crypto
Severity: Minor
Found in lib/private/Files/External/Service/UserStoragesService.php - About 35 mins to fix

    There are no issues that match your filters.

    Category
    Status