Sign upLogin

owncloud/core

View on GitHub
Star
lib/private/Files/External/StorageConfig.php

Summary

Maintainability
B
6 hrs
Test Coverage

StorageConfig has 29 functions (exceeds 20 allowed). Consider refactoring.
Open

class StorageConfig implements IStorageConfig {
    /**
     * Storage config id
     *
     * @var int
Severity: Minor
Found in lib/private/Files/External/StorageConfig.php - About 3 hrs to fix

    Method jsonSerialize has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function jsonSerialize() {
        $result = [];
        if ($this->id !== null) {
            $result['id'] = $this->id;
        }
    Severity: Minor
    Found in lib/private/Files/External/StorageConfig.php - About 1 hr to fix

      Function setBackendOptions has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public function setBackendOptions($backendOptions) {
        if ($this->getBackend() instanceof  Backend) {
            $parameters = $this->getBackend()->getParameters();
            foreach ($backendOptions as $key => $value) {
                if (isset($parameters[$key])) {
      Severity: Minor
      Found in lib/private/Files/External/StorageConfig.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function jsonSerialize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function jsonSerialize() {
        $result = [];
        if ($this->id !== null) {
            $result['id'] = $this->id;
        }
      Severity: Minor
      Found in lib/private/Files/External/StorageConfig.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status