Sign upLogin

owncloud/core

View on GitHub
Star
lib/private/Files/Type/Detection.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method mimeTypeIcon has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function mimeTypeIcon($mimetype) {
        $this->loadAliases();

        while (isset($this->mimeTypeAlias[$mimetype])) {
            $mimetype = $this->mimeTypeAlias[$mimetype];
Severity: Minor
Found in lib/private/Files/Type/Detection.php - About 1 hr to fix

    Method detect has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function detect($path) {
        $this->loadMappings();

        if (@\is_dir($path)) {
            // directories are easy
    Severity: Minor
    Found in lib/private/Files/Type/Detection.php - About 1 hr to fix

      Function detect has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public function detect($path) {
        $this->loadMappings();

        if (@\is_dir($path)) {
            // directories are easy
      Severity: Minor
      Found in lib/private/Files/Type/Detection.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function mimeTypeIcon has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function mimeTypeIcon($mimetype) {
        $this->loadAliases();

        while (isset($this->mimeTypeAlias[$mimetype])) {
            $mimetype = $this->mimeTypeAlias[$mimetype];
      Severity: Minor
      Found in lib/private/Files/Type/Detection.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                  return $this->mimetypeIcons[$mimetype];
      Severity: Major
      Found in lib/private/Files/Type/Detection.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return $this->mimetypeIcons[$mimetype];
        Severity: Major
        Found in lib/private/Files/Type/Detection.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return $this->mimetypeIcons[$mimetype];
          Severity: Major
          Found in lib/private/Files/Type/Detection.php - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status