owncloud/core

View on GitHub
lib/private/Group/Group.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function removeUser has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    public function removeUser($user) {
        $result = false;
        if ($this->emitter) {
            $this->emitter->emit('\OC\Group', 'preRemoveUser', [$this, $user]);
        }
Severity: Minor
Found in lib/private/Group/Group.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function addUser has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public function addUser($user) {
        if ($this->inGroup($user)) {
            return;
        }

Severity: Minor
Found in lib/private/Group/Group.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct($gid, $backends, $userManager, EventDispatcherInterface $eventDispatcher, $emitter = null, $displayName = null) {
Severity: Minor
Found in lib/private/Group/Group.php - About 45 mins to fix

    Function count has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public function count($search = '') {
            $users = false;
            foreach ($this->backends as $backend) {
                if ($backend->implementsActions(\OC\Group\Backend::COUNT_USERS)) {
                    if ($users === false) {
    Severity: Minor
    Found in lib/private/Group/Group.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function delete has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public function delete() {
            // Prevent users from deleting group admin
            if ($this->getGID() === 'admin') {
                return false;
            }
    Severity: Minor
    Found in lib/private/Group/Group.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status