Sign upLogin

owncloud/core

View on GitHub
Star
lib/private/Image/BmpToResource.php

Summary

Maintainability
A
2 hrs
Test Coverage

Function pixelArrayToImage has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    private function pixelArrayToImage() {
        $x = 0;
        $y = 0;
        foreach ($this->pixelArray as $pixelRow) {
            foreach ($pixelRow as $column) {
Severity: Minor
Found in lib/private/Image/BmpToResource.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getColors has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    private function getColors($raw) {
        $extra = \chr(0); // used to complement an argument to word or double word
        $colors = [];
        if (\in_array($this->header['bits'], [32, 24])) {
            $colors = @\unpack('V', $raw . $extra);
Severity: Minor
Found in lib/private/Image/BmpToResource.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status